forked from qt-creator/qt-creator
ProjectExplorer: Remove IDevice::createProcessListModel
All re-implementations are the same nowadays. Change-Id: I954b3c9ca296967a99ea548ade6282fba188249f Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
@@ -828,11 +828,6 @@ ProcessInterface *DockerDevice::createProcessInterface() const
|
||||
return new DockerProcessImpl(this->sharedFromThis(), d);
|
||||
}
|
||||
|
||||
ProcessList *DockerDevice::createProcessListModel(QObject *parent) const
|
||||
{
|
||||
return new ProcessList(sharedFromThis(), parent);
|
||||
}
|
||||
|
||||
DeviceTester *DockerDevice::createDeviceTester() const
|
||||
{
|
||||
return nullptr;
|
||||
|
@@ -74,7 +74,6 @@ public:
|
||||
Utils::ProcessInterface *createProcessInterface() const override;
|
||||
|
||||
bool canCreateProcessModel() const override { return true; }
|
||||
ProjectExplorer::ProcessList *createProcessListModel(QObject *parent) const override;
|
||||
bool hasDeviceTester() const override { return false; }
|
||||
ProjectExplorer::DeviceTester *createDeviceTester() const override;
|
||||
bool usableAsBuildDevice() const override;
|
||||
|
@@ -89,11 +89,6 @@ bool DesktopDevice::canCreateProcessModel() const
|
||||
return true;
|
||||
}
|
||||
|
||||
ProcessList *DesktopDevice::createProcessListModel(QObject *parent) const
|
||||
{
|
||||
return new ProcessList(sharedFromThis(), parent);
|
||||
}
|
||||
|
||||
DeviceProcessSignalOperation::Ptr DesktopDevice::signalOperation() const
|
||||
{
|
||||
return DeviceProcessSignalOperation::Ptr(new DesktopProcessSignalOperation());
|
||||
|
@@ -26,7 +26,6 @@ public:
|
||||
|
||||
IDeviceWidget *createWidget() override;
|
||||
bool canCreateProcessModel() const override;
|
||||
ProcessList *createProcessListModel(QObject *parent) const override;
|
||||
DeviceProcessSignalOperation::Ptr signalOperation() const override;
|
||||
QUrl toolControlChannel(const ControlChannelHint &) const override;
|
||||
bool usableAsBuildDevice() const override;
|
||||
|
@@ -187,7 +187,8 @@ void DeviceProcessesDialogPrivate::setDevice(const IDevice::ConstPtr &device)
|
||||
if (!device)
|
||||
return;
|
||||
|
||||
processList.reset(device->createProcessListModel());
|
||||
processList.reset(new ProcessList(device->sharedFromThis(), this));
|
||||
|
||||
QTC_ASSERT(processList, return);
|
||||
proxyModel.setSourceModel(processList->model());
|
||||
|
||||
|
@@ -391,13 +391,6 @@ PortsGatheringMethod IDevice::portsGatheringMethod() const
|
||||
return {filePath("netstat"), {"-a", "-n"}};
|
||||
},
|
||||
&Port::parseFromCommandOutput};
|
||||
};
|
||||
|
||||
ProcessList *IDevice::createProcessListModel(QObject *parent) const
|
||||
{
|
||||
Q_UNUSED(parent)
|
||||
QTC_ASSERT(false, qDebug("This should not have been called..."); return nullptr);
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
DeviceTester *IDevice::createDeviceTester() const
|
||||
|
@@ -32,16 +32,14 @@ namespace Utils {
|
||||
class CommandLine;
|
||||
class DeviceFileAccess;
|
||||
class Environment;
|
||||
class Icon;
|
||||
class PortList;
|
||||
class Port;
|
||||
class ProcessInterface;
|
||||
class Process;
|
||||
class ProcessInterface;
|
||||
} // Utils
|
||||
|
||||
namespace ProjectExplorer {
|
||||
|
||||
class ProcessList;
|
||||
class FileTransferInterface;
|
||||
class FileTransferSetupData;
|
||||
class Kit;
|
||||
@@ -142,7 +140,6 @@ public:
|
||||
|
||||
virtual PortsGatheringMethod portsGatheringMethod() const;
|
||||
virtual bool canCreateProcessModel() const { return false; }
|
||||
virtual ProcessList *createProcessListModel(QObject *parent = nullptr) const;
|
||||
virtual bool hasDeviceTester() const { return false; }
|
||||
virtual DeviceTester *createDeviceTester() const;
|
||||
|
||||
|
@@ -995,11 +995,6 @@ IDeviceWidget *LinuxDevice::createWidget()
|
||||
return new Internal::GenericLinuxDeviceConfigurationWidget(sharedFromThis());
|
||||
}
|
||||
|
||||
ProcessList *LinuxDevice::createProcessListModel(QObject *parent) const
|
||||
{
|
||||
return new ProcessList(sharedFromThis(), parent);
|
||||
}
|
||||
|
||||
DeviceTester *LinuxDevice::createDeviceTester() const
|
||||
{
|
||||
return new GenericLinuxDeviceTester;
|
||||
|
@@ -23,7 +23,6 @@ public:
|
||||
ProjectExplorer::IDeviceWidget *createWidget() override;
|
||||
|
||||
bool canCreateProcessModel() const override { return true; }
|
||||
ProjectExplorer::ProcessList *createProcessListModel(QObject *parent) const override;
|
||||
bool hasDeviceTester() const override { return true; }
|
||||
ProjectExplorer::DeviceTester *createDeviceTester() const override;
|
||||
ProjectExplorer::DeviceProcessSignalOperation::Ptr signalOperation() const override;
|
||||
|
Reference in New Issue
Block a user