feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Fix topic while pushing to newer Gerrit servers

Browse Source 
The Syntax "%topic=foo" was already introduced in
Gerrit 2.6, but until recently Gerrit supported
the old "refs/for/master/topic" syntax.

This support was dropped at some time, I was not
able to find when exactly.

[1] http://gerrit-documentation.storage.googleapis.com/ReleaseNotes/
ReleaseNotes-2.6.html

Fixes: QTCREATORBUG-31411
Change-Id: I96674abf4ce946f1064a5f01173f4ea81f5317f3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Andre Hartmann
2024-08-10 14:38:46 +02:00
committed by André Hartmann
parent 78e7059442
commit a76a4036f7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/git/gerrit/gerritpushdialog.cpp
View File

@@ -307,7 +307,7 @@ QString GerritPushDialog::pushTarget() const
target += '/' + selectedRemoteBranchName(); target += '/' + selectedRemoteBranchName();
const QString topic = selectedTopic(); const QString topic = selectedTopic();
if (!topic.isEmpty()) if (!topic.isEmpty())
target += '/' + topic; options << "topic=" + topic;
const QStringList reviewersInput = reviewers().split(',', Qt::SkipEmptyParts); const QStringList reviewersInput = reviewers().split(',', Qt::SkipEmptyParts);
for (const QString &reviewer : reviewersInput) for (const QString &reviewer : reviewersInput)