ClangTools: Avoid warnings from Q_OBJECT, too

Change-Id: I4540c1e2d9123af12e9f96976d6e37fe25aaf728
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This commit is contained in:
Nikolai Kosjar
2018-05-22 16:03:09 +02:00
parent 72aac9573d
commit a809462c91
4 changed files with 13 additions and 6 deletions

View File

@@ -556,11 +556,7 @@ private:
void addGlobalDiagnosticOptions()
{
m_options.append({
// Avoid undesired warnings from e.g. Q_OBJECT
QStringLiteral("-Wno-unknown-pragmas"),
QStringLiteral("-Wno-unknown-warning-option")
});
m_options += CppTools::ClangDiagnosticConfigsModel::globalDiagnosticOptions();
}
void addGlobalOptions()

View File

@@ -78,7 +78,8 @@ QStringList ClangTidyClazyRunner::constructCommandLineArguments(const QStringLis
arguments << QString("-fsyntax-only")
<< QString("-serialize-diagnostics")
<< QString(m_logFile);
<< QString(m_logFile)
<< ClangDiagnosticConfigsModel::globalDiagnosticOptions();
const ClangDiagnosticConfig::TidyMode tidyMode = m_diagnosticConfig.clangTidyMode();
if (tidyMode != ClangDiagnosticConfig::TidyMode::Disabled) {

View File

@@ -165,6 +165,15 @@ QVector<Core::Id> ClangDiagnosticConfigsModel::changedOrRemovedConfigs(
return changedConfigs;
}
QStringList ClangDiagnosticConfigsModel::globalDiagnosticOptions()
{
return {
// Avoid undesired warnings from e.g. Q_OBJECT
QStringLiteral("-Wno-unknown-pragmas"),
QStringLiteral("-Wno-unknown-warning-option")
};
}
int ClangDiagnosticConfigsModel::indexOfConfig(const Core::Id &id) const
{
return Utils::indexOf(m_diagnosticConfigs, [&](const ClangDiagnosticConfig &config) {

View File

@@ -53,6 +53,7 @@ public:
static QString displayNameWithBuiltinIndication(const ClangDiagnosticConfig &config);
static QVector<Core::Id> changedOrRemovedConfigs(const ClangDiagnosticConfigs &oldConfigs,
const ClangDiagnosticConfigs &newConfigs);
static QStringList globalDiagnosticOptions();
private:
ClangDiagnosticConfigs m_diagnosticConfigs;