feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ModelingLib: Avoid using keys()

Browse Source 
Instead, iterate directly over the container.

Notably, sorting the result of keys() didn't play any
significant role in this contexts.

Change-Id: Iba82f3d503143ff0036509d0bf08c87747aeb40c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Jarek Kobus
2024-01-10 22:16:05 +01:00
parent b406bf36f5
commit a88dac86c0
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libs/modelinglib/qmt/style/defaultstyleengine.cpp
View File

@@ -325,11 +325,9 @@ const Style *DefaultStyleEngine::applyObjectStyle(const Style *baseStyle, const
} }
int depth = 0; int depth = 0;
if (!depths.isEmpty()) { if (!depths.isEmpty()) {
const QList<int> keys = Utils::sorted(depths.keys()); for (auto it = depths.cbegin(); it != depths.cend(); ++it) {
for (int d : keys) { if (it->m_elementType == elementType
DepthProperties properties = depths.value(d); && areStackingRoles(it->m_visualPrimaryRole, it->m_visualSecondaryRole,
if (properties.m_elementType == elementType
&& areStackingRoles(properties.m_visualPrimaryRole, properties.m_visualSecondaryRole,
styledVisualPrimaryRole, styledVisualSecondaryRole)) { styledVisualPrimaryRole, styledVisualSecondaryRole)) {
++depth; ++depth;
} else { } else {