Add final specifies to classes

Warning -Wfinal-dtor-non-final-class in clang trunk

Change-Id: I2bf17064bf8898eab10b82b69583a283157766d0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Igor Sidorov
2020-01-29 04:15:25 +03:00
parent aeb7ef6b37
commit a9e40ad14c
65 changed files with 67 additions and 67 deletions

View File

@@ -30,7 +30,7 @@
namespace Android {
namespace Internal {
class AndroidPlugin : public ExtensionSystem::IPlugin
class AndroidPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Android.json")

View File

@@ -62,7 +62,7 @@ namespace Internal {
* be executed in the build process)
*/
class AutotoolsProjectPlugin : public ExtensionSystem::IPlugin
class AutotoolsProjectPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "AutotoolsProjectManager.json")

View File

@@ -45,7 +45,7 @@ class Bookmark;
class BookmarksPlugin;
class BookmarkContext;
class BookmarkManager : public QAbstractItemModel
class BookmarkManager final : public QAbstractItemModel
{
Q_OBJECT
@@ -122,7 +122,7 @@ private:
QItemSelectionModel *m_selectionModel;
};
class BookmarkView : public Utils::ListView
class BookmarkView final : public Utils::ListView
{
Q_OBJECT

View File

@@ -30,7 +30,7 @@
namespace Bookmarks {
namespace Internal {
class BookmarksPlugin : public ExtensionSystem::IPlugin
class BookmarksPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Bookmarks.json")

View File

@@ -30,7 +30,7 @@
namespace Qdb {
namespace Internal {
class QdbPlugin : public ExtensionSystem::IPlugin
class QdbPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Boot2Qt.json")

View File

@@ -34,7 +34,7 @@ namespace Internal {
ProjectExplorer::ProjectPanelFactory *projectPanelFactory();
class ClangToolsPlugin : public ExtensionSystem::IPlugin
class ClangToolsPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "ClangTools.json")

View File

@@ -30,7 +30,7 @@
namespace ClassView {
namespace Internal {
class ClassViewPlugin : public ExtensionSystem::IPlugin
class ClassViewPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "ClassView.json")

View File

@@ -51,7 +51,7 @@ class CMakeBuildConfiguration;
class CMakeBuildSystem;
class CMakeProjectNode;
class BuildDirManager : public QObject
class BuildDirManager final : public QObject
{
Q_OBJECT

View File

@@ -42,7 +42,7 @@ class BuildDirManager;
class CMakeBuildSystem;
class CMakeBuildSettingsWidget;
class CMakeBuildConfiguration : public ProjectExplorer::BuildConfiguration
class CMakeBuildConfiguration final : public ProjectExplorer::BuildConfiguration
{
Q_OBJECT

View File

@@ -46,7 +46,7 @@ class CMakeBuildConfiguration;
// CMakeBuildSystem:
// --------------------------------------------------------------------
class CMakeBuildSystem : public ProjectExplorer::BuildSystem
class CMakeBuildSystem final : public ProjectExplorer::BuildSystem
{
Q_OBJECT

View File

@@ -111,7 +111,7 @@ void CMakeEditor::contextHelp(const HelpCallback &callback) const
// CMakeEditorWidget
//
class CMakeEditorWidget : public TextEditorWidget
class CMakeEditorWidget final : public TextEditorWidget
{
public:
~CMakeEditorWidget() final = default;

View File

@@ -39,7 +39,7 @@
namespace CMakeProjectManager {
class CMAKE_EXPORT CMakeProject : public ProjectExplorer::Project
class CMAKE_EXPORT CMakeProject final : public ProjectExplorer::Project
{
Q_OBJECT

View File

@@ -237,7 +237,7 @@ public:
std::vector<FileApiDetails::TargetDetails> targetDetails;
};
class FileApiParser : public QObject
class FileApiParser final : public QObject
{
Q_OBJECT

View File

@@ -45,7 +45,7 @@ namespace Internal {
class FileApiQtcData;
class FileApiReader : public BuildDirReader
class FileApiReader final : public BuildDirReader
{
Q_OBJECT

View File

@@ -41,7 +41,7 @@ namespace Utils { class QtcProcess; }
namespace CMakeProjectManager {
namespace Internal {
class ServerMode : public QObject
class ServerMode final : public QObject
{
Q_OBJECT

View File

@@ -38,7 +38,7 @@ namespace ProjectExplorer { class ProjectNode; }
namespace CMakeProjectManager {
namespace Internal {
class ServerModeReader : public BuildDirReader
class ServerModeReader final : public BuildDirReader
{
Q_OBJECT

View File

@@ -37,7 +37,7 @@ namespace Utils { class QtcProcess; }
namespace CMakeProjectManager {
namespace Internal {
class TeaLeafReader : public BuildDirReader
class TeaLeafReader final : public BuildDirReader
{
Q_OBJECT

View File

@@ -37,7 +37,7 @@ class IEditor;
* to the main editor widget itself.
*/
class CORE_EXPORT DesignMode : public IMode
class CORE_EXPORT DesignMode final : public IMode
{
Q_OBJECT

View File

@@ -59,7 +59,7 @@ class EditorManagerPrivate;
class MainWindow;
} // namespace Internal
class CORE_EXPORT EditorManagerPlaceHolder : public QWidget
class CORE_EXPORT EditorManagerPlaceHolder final : public QWidget
{
Q_OBJECT
public:

View File

@@ -36,7 +36,7 @@
namespace Core {
class CORE_EXPORT UrlLocatorFilter : public Core::ILocatorFilter
class CORE_EXPORT UrlLocatorFilter final : public Core::ILocatorFilter
{
Q_OBJECT
public:

View File

@@ -48,7 +48,7 @@ namespace Internal {
struct CppFileSettings;
class CppToolsPluginPrivate;
class CppToolsPlugin : public ExtensionSystem::IPlugin
class CppToolsPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "CppTools.json")

View File

@@ -110,7 +110,7 @@ private:
using GlobalBreakpoint = QPointer<GlobalBreakpointItem>;
using GlobalBreakpoints = QList<GlobalBreakpoint>;
class BreakpointItem : public QObject, public Utils::TypedTreeItem<SubBreakpointItem>
class BreakpointItem final : public QObject, public Utils::TypedTreeItem<SubBreakpointItem>
{
Q_DECLARE_TR_FUNCTIONS(Debugger::Internal::BreakHandler)

View File

@@ -187,7 +187,7 @@ public:
Utils::QtcProcess m_proc;
};
class CoreUnpacker : public RunWorker
class CoreUnpacker final : public RunWorker
{
public:
CoreUnpacker(RunControl *runControl, const QString &coreFileName)

View File

@@ -34,7 +34,7 @@ namespace Internal {
class DebuggerEngine;
class EngineManager : public QObject
class EngineManager final : public QObject
{
Q_OBJECT

View File

@@ -65,7 +65,7 @@ struct CoreInfo
const QString &coreFile);
};
class GdbEngine : public CppDebuggerEngine
class GdbEngine final : public CppDebuggerEngine
{
Q_OBJECT

View File

@@ -45,7 +45,7 @@ class DebuggerPane;
class CombinedPane;
class InputPane;
class LogWindow : public QWidget
class LogWindow final : public QWidget
{
Q_OBJECT
@@ -85,7 +85,7 @@ private:
DebuggerEngine *m_engine;
};
class GlobalLogWindow : public QWidget
class GlobalLogWindow final : public QWidget
{
Q_OBJECT

View File

@@ -31,7 +31,7 @@
namespace GlslEditor {
namespace Internal {
class GlslEditorPlugin : public ExtensionSystem::IPlugin
class GlslEditorPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "GLSLEditor.json")

View File

@@ -33,7 +33,7 @@
namespace Help {
namespace Internal {
class HelpIndexFilter : public Core::ILocatorFilter
class HelpIndexFilter final : public Core::ILocatorFilter
{
Q_OBJECT

View File

@@ -38,7 +38,7 @@ namespace Internal {
class HelpWidget;
class HelpViewer;
class HelpPlugin : public ExtensionSystem::IPlugin
class HelpPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Help.json")

View File

@@ -30,7 +30,7 @@
namespace Ios {
namespace Internal {
class IosPlugin : public ExtensionSystem::IPlugin
class IosPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Ios.json")

View File

@@ -35,7 +35,7 @@ namespace Internal {
namespace Ui { class IosSettingsWidget; }
class IosSettingsWidget : public Core::IOptionsPageWidget
class IosSettingsWidget final : public Core::IOptionsPageWidget
{
Q_DECLARE_TR_FUNCTIONS(Ios::Internal::IosSettingsWidget)

View File

@@ -39,7 +39,7 @@ namespace Internal {
namespace Ui { class MacroOptionsWidget; }
class MacroOptionsWidget : public Core::IOptionsPageWidget
class MacroOptionsWidget final : public Core::IOptionsPageWidget
{
Q_OBJECT

View File

@@ -30,7 +30,7 @@
namespace Macros {
namespace Internal {
class MacrosPlugin : public ExtensionSystem::IPlugin
class MacrosPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Macros.json")

View File

@@ -29,7 +29,7 @@
namespace Nim {
class NimPlugin : public ExtensionSystem::IPlugin
class NimPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Nim.json")

View File

@@ -33,7 +33,7 @@
namespace PerfProfiler {
class PERFPROFILER_EXPORT PerfSettings : public ProjectExplorer::ISettingsAspect
class PERFPROFILER_EXPORT PerfSettings final : public ProjectExplorer::ISettingsAspect
{
Q_OBJECT
Q_PROPERTY(QStringList perfRecordArguments READ perfRecordArguments NOTIFY changed)

View File

@@ -36,7 +36,7 @@
namespace PerfProfiler {
namespace Internal {
class ResourcesRenderPassState : public Timeline::TimelineRenderPass::State
class ResourcesRenderPassState final : public Timeline::TimelineRenderPass::State
{
public:
ResourcesRenderPassState();

View File

@@ -47,7 +47,7 @@ namespace Internal {
namespace Ui { class DeviceSettingsWidget; }
class NameValidator;
class DeviceSettingsWidget : public Core::IOptionsPageWidget
class DeviceSettingsWidget final : public Core::IOptionsPageWidget
{
Q_OBJECT
public:

View File

@@ -30,7 +30,7 @@
namespace Python {
namespace Internal {
class PythonPlugin : public ExtensionSystem::IPlugin
class PythonPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Python.json")

View File

@@ -42,7 +42,7 @@ namespace Internal {
class QbsBuildStep;
class QbsProject;
class QbsBuildConfiguration : public ProjectExplorer::BuildConfiguration
class QbsBuildConfiguration final : public ProjectExplorer::BuildConfiguration
{
Q_OBJECT

View File

@@ -68,7 +68,7 @@ private:
mutable ProjectExplorer::ProjectImporter *m_importer = nullptr;
};
class QbsBuildSystem : public ProjectExplorer::BuildSystem
class QbsBuildSystem final : public ProjectExplorer::BuildSystem
{
Q_OBJECT

View File

@@ -37,7 +37,7 @@ namespace Internal {
class QbsProject;
class QbsProjectManagerPluginPrivate;
class QbsProjectManagerPlugin : public ExtensionSystem::IPlugin
class QbsProjectManagerPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "QbsProjectManager.json")

View File

@@ -51,7 +51,7 @@ namespace QmakeProjectManager {
namespace Internal { class CentralizedFolderWatcher; }
class QMAKEPROJECTMANAGER_EXPORT QmakeProject : public ProjectExplorer::Project
class QMAKEPROJECTMANAGER_EXPORT QmakeProject final : public ProjectExplorer::Project
{
Q_OBJECT

View File

@@ -30,7 +30,7 @@
namespace QmakeProjectManager {
namespace Internal {
class QmakeProjectManagerPlugin : public ExtensionSystem::IPlugin
class QmakeProjectManagerPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "QmakeProjectManager.json")

View File

@@ -45,7 +45,7 @@ class QmlDesignerPluginPrivate;
namespace Internal { class DesignModeWidget; }
class QMLDESIGNERCORE_EXPORT QmlDesignerPlugin : public ExtensionSystem::IPlugin
class QMLDESIGNERCORE_EXPORT QmlDesignerPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "QmlDesigner.json")

View File

@@ -35,7 +35,7 @@ namespace Internal {
class QmlJSQuickFixAssistProvider;
class QmlJSEditorPlugin : public ExtensionSystem::IPlugin
class QmlJSEditorPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "QmlJSEditor.json")

View File

@@ -30,7 +30,7 @@
namespace QmlJSTools {
namespace Internal {
class QmlJSToolsPlugin : public ExtensionSystem::IPlugin
class QmlJSToolsPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "QmlJSTools.json")

View File

@@ -30,7 +30,7 @@
namespace QmlProjectManager {
namespace Internal {
class QmlProjectPlugin: public ExtensionSystem::IPlugin
class QmlProjectPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "QmlProjectManager.json")

View File

@@ -30,7 +30,7 @@
namespace Qnx {
namespace Internal {
class QnxPlugin : public ExtensionSystem::IPlugin
class QnxPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Qnx.json")

View File

@@ -30,7 +30,7 @@
namespace QtSupport {
namespace Internal {
class QtSupportPlugin : public ExtensionSystem::IPlugin
class QtSupportPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "QtSupport.json")

View File

@@ -83,7 +83,7 @@ private:
Private * const d;
};
class REMOTELINUX_EXPORT GenericLinuxDeviceConfigurationWizardFinalPage : public QWizardPage
class REMOTELINUX_EXPORT GenericLinuxDeviceConfigurationWizardFinalPage final : public QWizardPage
{
Q_OBJECT
public:

View File

@@ -30,7 +30,7 @@
namespace RemoteLinux {
namespace Internal {
class RemoteLinuxPlugin : public ExtensionSystem::IPlugin
class RemoteLinuxPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "RemoteLinux.json")

View File

@@ -30,7 +30,7 @@
namespace StudioWelcome {
namespace Internal {
class StudioWelcomePlugin : public ExtensionSystem::IPlugin
class StudioWelcomePlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "StudioWelcome.json")

View File

@@ -33,7 +33,7 @@ namespace Utils { class FilePath; }
namespace TaskList {
namespace Internal {
class TaskListPlugin : public ExtensionSystem::IPlugin
class TaskListPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "TaskList.json")

View File

@@ -67,7 +67,7 @@ private:
bool m_isFunction;
};
class TEXTEDITOR_EXPORT KeywordsFunctionHintModel : public IFunctionHintProposalModel
class TEXTEDITOR_EXPORT KeywordsFunctionHintModel final : public IFunctionHintProposalModel
{
public:
KeywordsFunctionHintModel(const QStringList &functionSymbols);

View File

@@ -32,7 +32,7 @@ namespace Internal {
class LineNumberFilter;
class TextEditorPlugin : public ExtensionSystem::IPlugin
class TextEditorPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "TextEditor.json")

View File

@@ -32,7 +32,7 @@ namespace Internal {
class ValgrindGlobalSettings;
class CallgrindTool : public QObject
class CallgrindTool final : public QObject
{
Q_OBJECT

View File

@@ -33,7 +33,7 @@ namespace Internal {
class MemcheckToolRunner;
class MemcheckTool : public QObject
class MemcheckTool final : public QObject
{
Q_OBJECT

View File

@@ -32,7 +32,7 @@
namespace Valgrind {
namespace Internal {
class ValgrindPlugin : public ExtensionSystem::IPlugin
class ValgrindPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Valgrind.json")

View File

@@ -122,7 +122,7 @@ private:
Id m_activePage;
};
class WelcomePlugin : public ExtensionSystem::IPlugin
class WelcomePlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Welcome.json")

View File

@@ -30,7 +30,7 @@
namespace WinRt {
namespace Internal {
class WinRtPlugin : public ExtensionSystem::IPlugin
class WinRtPlugin final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "WinRt.json")

View File

@@ -35,7 +35,7 @@
namespace Plugin1 {
class PLUGIN1_EXPORT MyPlugin1 : public ExtensionSystem::IPlugin
class PLUGIN1_EXPORT MyPlugin1 final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "plugin" FILE "plugin1.json")

View File

@@ -35,7 +35,7 @@
namespace Plugin2 {
class PLUGIN2_EXPORT MyPlugin2 : public ExtensionSystem::IPlugin
class PLUGIN2_EXPORT MyPlugin2 final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "plugin" FILE "plugin2.json")

View File

@@ -35,7 +35,7 @@
namespace Plugin3 {
class PLUGIN3_EXPORT MyPlugin3 : public ExtensionSystem::IPlugin
class PLUGIN3_EXPORT MyPlugin3 final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "plugin" FILE "plugin3.json")

View File

@@ -29,7 +29,7 @@
namespace Plugin1 {
class MyPlugin1 : public ExtensionSystem::IPlugin
class MyPlugin1 final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "plugin" FILE "plugin1.json")

View File

@@ -29,7 +29,7 @@
namespace Plugin2 {
class MyPlugin2 : public ExtensionSystem::IPlugin
class MyPlugin2 final : public ExtensionSystem::IPlugin
{
Q_OBJECT
Q_PLUGIN_METADATA(IID "plugin" FILE "plugin2.json")