feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmakeProject: Make QMakeBuildConfiguration less visible

Browse Source 
... in QmakeMakeStep interface.

Change-Id: I19bfa0470dc709d79563640bc4dc4f7fc0d5d8f3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-05-16 17:38:35 +02:00
parent 5fa3ed25fc
commit acc0080146
2 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/qmakeprojectmanager/qmakemakestep.cpp
View File

@@ -64,14 +64,9 @@ QmakeMakeStep::QmakeMakeStep(BuildStepList *bsl)
} }
} }
QmakeBuildConfiguration *QmakeMakeStep::qmakeBuildConfiguration() const
{
return static_cast<QmakeBuildConfiguration *>(buildConfiguration());
}
bool QmakeMakeStep::init() bool QmakeMakeStep::init()
{ {
QmakeBuildConfiguration *bc = qmakeBuildConfiguration(); const auto bc = static_cast<QmakeBuildConfiguration *>(buildConfiguration());
if (!bc) if (!bc)
emit addTask(Task::buildConfigurationMissingTask()); emit addTask(Task::buildConfigurationMissingTask());

5
src/plugins/qmakeprojectmanager/qmakemakestep.h
View File

@@ -30,9 +30,6 @@
#include <projectexplorer/makestep.h> #include <projectexplorer/makestep.h>
namespace QmakeProjectManager { namespace QmakeProjectManager {
class QmakeBuildConfiguration;
namespace Internal { namespace Internal {
class QmakeMakeStepFactory : public ProjectExplorer::BuildStepFactory class QmakeMakeStepFactory : public ProjectExplorer::BuildStepFactory
@@ -52,8 +49,6 @@ class QMAKEPROJECTMANAGER_EXPORT QmakeMakeStep : public ProjectExplorer::MakeSte
public: public:
explicit QmakeMakeStep(ProjectExplorer::BuildStepList *bsl); explicit QmakeMakeStep(ProjectExplorer::BuildStepList *bsl);
QmakeBuildConfiguration *qmakeBuildConfiguration() const;
private: private:
void finish(bool success) override; void finish(bool success) override;
bool init() override; bool init() override;