AbstractRemoteLinuxDeployService: Remove SettingUpDevice phase

No subclass was using it currently, so simply internals.

Change-Id: Ie9574fdb2d6a26d089f3059acca407d65c59b2cc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>

src/plugins/remotelinux/abstractremotelinuxdeployservice.cpp

@@ -43,7 +43,7 @@ namespace RemoteLinux {
 namespace Internal {
 
 namespace {
-enum State { Inactive, SettingUpDevice, Deploying };
+enum State { Inactive, Deploying };
 } // anonymous namespace
 
 class AbstractRemoteLinuxDeployServicePrivate
@@ -131,8 +131,8 @@ void AbstractRemoteLinuxDeployService::start()
         return;
     }
 
-    d->state = SettingUpDevice;
-    doDeviceSetup();
+    d->state = Deploying;
+    doDeploy();
 }
 
 void AbstractRemoteLinuxDeployService::stop()
@@ -140,17 +140,9 @@ void AbstractRemoteLinuxDeployService::stop()
     if (d->stopRequested)
         return;
 
-    switch (d->state) {
-    case Inactive:
-        break;
-    case SettingUpDevice:
-        d->stopRequested = true;
-        stopDeviceSetup();
-        break;
-    case Deploying:
+    if (d->state == Deploying) {
         d->stopRequested = true;
         stopDeployment();
-        break;
     }
 }
 
@@ -171,19 +163,6 @@ void AbstractRemoteLinuxDeployService::importDeployTimes(const QVariantMap &map)
     d->deployTimes.importDeployTimes(map);
 }
 
-void AbstractRemoteLinuxDeployService::handleDeviceSetupDone(bool success)
-{
-    QTC_ASSERT(d->state == SettingUpDevice, return);
-
-    if (!success || d->stopRequested) {
-        setFinished();
-        return;
-    }
-
-    d->state = Deploying;
-    doDeploy();
-}
-
 void AbstractRemoteLinuxDeployService::handleDeploymentDone()
 {
     QTC_ASSERT(d->state == Deploying, return);

src/plugins/remotelinux/abstractremotelinuxdeployservice.h

@@ -96,13 +96,8 @@ protected:
     bool hasRemoteFileChanged(const ProjectExplorer::DeployableFile &deployableFile,
                               const QDateTime &remoteTimestamp) const;
 
-    void handleDeviceSetupDone(bool success);
     void handleDeploymentDone();
 
-    // Should do things needed *before* connecting. Call default implementation afterwards.
-    virtual void doDeviceSetup() { handleDeviceSetupDone(true); }
-    virtual void stopDeviceSetup() { handleDeviceSetupDone(false); }
-
     void setFinished();
 
 private:

src/plugins/remotelinux/abstractuploadandinstallpackageservice.cpp

@@ -85,18 +85,6 @@ bool AbstractUploadAndInstallPackageService::isDeploymentNecessary() const
     return hasLocalFileChanged(DeployableFile(d->packageFilePath, QString()));
 }
 
-void AbstractUploadAndInstallPackageService::doDeviceSetup()
-{
-    QTC_ASSERT(d->state == Inactive, return);
-    AbstractRemoteLinuxDeployService::doDeviceSetup();
-}
-
-void AbstractUploadAndInstallPackageService::stopDeviceSetup()
-{
-    QTC_ASSERT(d->state == Inactive, return);
-    AbstractRemoteLinuxDeployService::stopDeviceSetup();
-}
-
 void AbstractUploadAndInstallPackageService::doDeploy()
 {
     QTC_ASSERT(d->state == Inactive, return);

src/plugins/remotelinux/abstractuploadandinstallpackageservice.h

@@ -57,8 +57,6 @@ private:
     virtual QString uploadDir() const; // Defaults to remote user's home directory.
 
     bool isDeploymentNecessary() const override;
-    void doDeviceSetup() override;
-    void stopDeviceSetup() override;
     void doDeploy() override;
     void stopDeployment() override;
 

src/plugins/remotelinux/genericdirectuploadservice.cpp

@@ -129,18 +129,6 @@ bool GenericDirectUploadService::isDeploymentNecessary() const
     return !d->deployableFiles.isEmpty();
 }
 
-void GenericDirectUploadService::doDeviceSetup()
-{
-    QTC_ASSERT(d->state == Inactive, return);
-    AbstractRemoteLinuxDeployService::doDeviceSetup();
-}
-
-void GenericDirectUploadService::stopDeviceSetup()
-{
-    QTC_ASSERT(d->state == Inactive, return);
-    AbstractRemoteLinuxDeployService::stopDeviceSetup();
-}
-
 void GenericDirectUploadService::doDeploy()
 {
     QTC_ASSERT(d->state == Inactive, setFinished(); return);

src/plugins/remotelinux/genericdirectuploadservice.h

@@ -55,9 +55,6 @@ public:
 protected:
     bool isDeploymentNecessary() const override;
 
-    void doDeviceSetup() override;
-    void stopDeviceSetup() override;
-
     void doDeploy() override;
     void stopDeployment() override;
 

src/plugins/remotelinux/remotelinuxcheckforfreediskspacestep.cpp

@@ -54,14 +54,11 @@ public:
     void setRequiredSpaceInBytes(quint64 sizeInBytes);
 
 private:
-    void deployAndFinish();
     bool isDeploymentNecessary() const override { return true; }
 
     CheckResult isDeploymentPossible() const override;
-    void doDeviceSetup() final { deployAndFinish(); }
-    void stopDeviceSetup() final { }
 
-    void doDeploy() final {}
+    void doDeploy() final;
     void stopDeployment() final {}
 
     QString m_pathToCheck;
@@ -78,7 +75,7 @@ void RemoteLinuxCheckForFreeDiskSpaceService::setRequiredSpaceInBytes(quint64 si
     m_requiredSpaceInBytes = sizeInBytes;
 }
 
-void RemoteLinuxCheckForFreeDiskSpaceService::deployAndFinish()
+void RemoteLinuxCheckForFreeDiskSpaceService::doDeploy()
 {
     auto cleanup = qScopeGuard([this] { setFinished(); });
     const FilePath path = deviceConfiguration()->filePath(m_pathToCheck);
@@ -86,6 +83,7 @@ void RemoteLinuxCheckForFreeDiskSpaceService::deployAndFinish()
     if (freeSpace < 0) {
         emit errorMessage(tr("Cannot get info about free disk space for \"%1\"")
                 .arg(path.toUserOutput()));
+        handleDeploymentDone();
         return;
     }
 
@@ -97,11 +95,13 @@ void RemoteLinuxCheckForFreeDiskSpaceService::deployAndFinish()
         emit errorMessage(tr("The remote file system has only %n megabytes of free space, "
                 "but %1 megabytes are required.", nullptr, freeSpaceMB)
                           .arg(requiredSpaceMB));
+        handleDeploymentDone();
         return;
     }
 
     emit progressMessage(tr("The remote file system has %n megabytes of free space, going ahead.",
                             nullptr, freeSpaceMB));
+    handleDeploymentDone();
 }
 
 CheckResult RemoteLinuxCheckForFreeDiskSpaceService::isDeploymentPossible() const