Tests: Emit coreAboutToClose() before exiting

Now address sanitizer will not show false positives.

Change-Id: Ieeb4dc31697920ed1ca542f5647f4cb0b23a29ab
Task-number: QTCREATORBUG-14713
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

src/libs/extensionsystem/pluginmanager.cpp

@@ -847,7 +847,6 @@ void PluginManagerPrivate::nextDelayedInitialize()
     \internal
 */
 PluginManagerPrivate::PluginManagerPrivate(PluginManager *pluginManager) :
-    m_failedTests(0),
     delayedInitializeTimer(0),
     shutdownEventLoop(0),
     m_profileElapsedMS(0),
@@ -1127,6 +1126,7 @@ void PluginManagerPrivate::startTests()
         return;
     }
 
+    int failedTests = 0;
     foreach (const PluginManagerPrivate::TestSpec &testSpec, testSpecs) {
         IPlugin *plugin = testSpec.pluginSpec->plugin();
         if (!plugin)
@@ -1144,10 +1144,10 @@ void PluginManagerPrivate::startTests()
                 ? generateCompleteTestPlan(plugin, testObjects)
                 : generateCustomTestPlan(plugin, testObjects, testSpec.testFunctionsOrObjects);
 
-        m_failedTests += executeTestPlan(testPlan);
+        failedTests += executeTestPlan(testPlan);
     }
-    if (!testSpecs.isEmpty())
-        QTimer::singleShot(1, this, SLOT(exitWithNumberOfFailedTests()));
+
+    QTimer::singleShot(0, this, [failedTests]() { emit m_instance->testsFinished(failedTests); });
 }
 #endif
 
@@ -1270,14 +1270,6 @@ void PluginManagerPrivate::asyncShutdownFinished()
         shutdownEventLoop->exit();
 }
 
-/*!
-    \internal
-*/
-void PluginManagerPrivate::exitWithNumberOfFailedTests()
-{
-    QCoreApplication::exit(m_failedTests);
-}
-
 /*!
     \internal
 */

src/libs/extensionsystem/pluginmanager.h

@@ -158,6 +158,7 @@ signals:
 
     void pluginsChanged();
     void initializationDone();
+    void testsFinished(int failedTests);
 
 public slots:
     void remoteArguments(const QString &serializedArguments, QObject *socket);

src/libs/extensionsystem/pluginmanager_p.h

@@ -102,7 +102,6 @@ public:
     QHash<QString, PluginCollection *> pluginCategories;
     QList<PluginSpec *> pluginSpecs;
     QList<TestSpec> testSpecs;
-    int m_failedTests;
     QStringList pluginPaths;
     QString pluginIID;
     QList<QObject *> allObjects; // ### make this a QList<QPointer<QObject> > > ?
@@ -138,7 +137,6 @@ public:
 private slots:
     void nextDelayedInitialize();
     void asyncShutdownFinished();
-    void exitWithNumberOfFailedTests();
 
 private:
     PluginCollection *defaultCollection;

src/plugins/coreplugin/icore.cpp

@@ -323,6 +323,10 @@ ICore::ICore(MainWindow *mainwindow)
     // Save settings once after all plugins are initialized:
     connect(PluginManager::instance(), SIGNAL(initializationDone()),
             this, SLOT(saveSettings()));
+    connect(PluginManager::instance(), &PluginManager::testsFinished, [this] (int failedTests) {
+        emit coreAboutToClose();
+        QCoreApplication::exit(failedTests);
+    });
     connect(m_mainwindow, SIGNAL(newItemDialogRunningChanged()),
             this, SIGNAL(newItemDialogRunningChanged()));
 }