ProjectExplorer: Remove todos

Change-Id: I22af9f79feb1b4a1638a3c30b094cce3a06300b6
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
This commit is contained in:
Daniel Teske
2012-05-03 16:10:00 +02:00
parent 5a041c513d
commit aef919b31c
6 changed files with 5 additions and 21 deletions

View File

@@ -62,7 +62,7 @@ public:
virtual QString buildDirectory() const = 0;
// TODO: Maybe the BuildConfiguration is not the best place for the environment
// Maybe the BuildConfiguration is not the best place for the environment
virtual Utils::Environment baseEnvironment() const;
QString baseEnvironmentText() const;
Utils::Environment environment() const;
@@ -78,7 +78,7 @@ public:
// Creates a suitable outputparser for custom build steps
// (based on the tool chain)
// TODO this is not great API
// this is not great API
// it's mainly so that custom build systems are better integrated
// with the generic project manager
virtual IOutputParser *createOutputParser() const = 0;

View File

@@ -69,9 +69,6 @@ static inline QString msgProgress(int progress, int total)
}
namespace ProjectExplorer {
//NBS TODO this class has too many different variables which hold state:
// m_buildQueue, m_running, m_canceled, m_progress, m_maxProgress, m_activeBuildSteps and ...
// I might need to reduce that.
struct BuildManagerPrivate {
BuildManagerPrivate();

View File

@@ -237,7 +237,7 @@ struct ProjectExplorerPluginPrivate {
static const int m_maxRecentProjects = 7;
QString m_lastOpenDirectory;
RunConfiguration *m_delayedRunConfiguration; // TODO this is not right
RunConfiguration *m_delayedRunConfiguration;
RunMode m_runMode;
QString m_projectFilterString;
Internal::MiniProjectTargetSelector * m_targetSelector;

View File

@@ -275,8 +275,8 @@ void ProjectWindow::extensionsInitialized()
void ProjectWindow::aboutToShutdown()
{
showProperties(-1, -1); // TODO that's a bit stupid, but otherwise stuff is still
// connected to the session
showProperties(-1, -1); // that's a bit stupid, but otherwise stuff is still
// connected to the session
disconnect(ProjectExplorerPlugin::instance()->session(), 0, this, 0);
}
@@ -382,16 +382,6 @@ void ProjectWindow::deregisterProject(ProjectExplorer::Project *project)
m_tabWidget->removeTab(index);
}
void ProjectWindow::restoreStatus()
{
// TODO
}
void ProjectWindow::saveStatus()
{
// TODO
}
void ProjectWindow::startupProjectChanged(ProjectExplorer::Project *p)
{
int index = m_tabIndexToProject.indexOf(p);

View File

@@ -89,8 +89,6 @@ public slots:
private slots:
void targetFactoriesChanged();
void showProperties(int index, int subIndex);
void restoreStatus();
void saveStatus();
void registerProject(ProjectExplorer::Project*);
void deregisterProject(ProjectExplorer::Project*);
void startupProjectChanged(ProjectExplorer::Project *);

View File

@@ -60,7 +60,6 @@ public:
void popup(bool withFocus);
// TODO now there are two places for icons
QIcon taskTypeIcon(ProjectExplorer::Task::TaskType t) const;
signals:
void categoryAdded(const Core::Id &categoryId, const QString &displayName, bool visible);