feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Axivion: Fix clazy warning about mixing const and mutable iterators

Browse Source 
Change-Id: Ief898ff2febb958f3f68a64ddcb614479854600f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
This commit is contained in:
hjk
2024-02-27 15:34:32 +01:00
parent e8b3887dbf
commit af712dc0e7
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/axivion/axivionplugin.cpp
View File

@@ -69,14 +69,15 @@ QIcon iconForIssue(const std::optional<Dto::IssueKind> &issueKind)
return {}; return {};
static QHash<Dto::IssueKind, QIcon> prefixToIcon; static QHash<Dto::IssueKind, QIcon> prefixToIcon;
auto it = prefixToIcon.constFind(*issueKind); auto it = prefixToIcon.constFind(*issueKind);
if (it == prefixToIcon.constEnd()) { if (it != prefixToIcon.constEnd())
const auto prefix = Dto::IssueKindMeta::enumToStr(*issueKind); return *it;
const Icon icon({{FilePath::fromString(":/axivion/images/button-" + prefix + ".png"),
Theme::PaletteButtonText}}, Icon::Tint); const QLatin1String prefix = Dto::IssueKindMeta::enumToStr(*issueKind);
it = prefixToIcon.insert(*issueKind, icon.icon()); const Icon icon({{FilePath::fromString(":/axivion/images/button-" + prefix + ".png"),
} Theme::PaletteButtonText}}, Icon::Tint);
return it.value(); return prefixToIcon.insert(*issueKind, icon.icon()).value();
} }
QString anyToSimpleString(const Dto::Any &any) QString anyToSimpleString(const Dto::Any &any)