feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: handle some TODO comments

Browse Source 
Change-Id: Id1848dccc0a9b43ed77c0bd99329a0b81705a17a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Assam Boudjelthia
2020-06-30 16:07:09 +03:00
parent fa81549844
commit b085091526
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/android/androiddeployqtstep.cpp
View File

@@ -163,8 +163,12 @@ Core::Id AndroidDeployQtStep::stepId()
bool AndroidDeployQtStep::init() bool AndroidDeployQtStep::init()
{ {
QtSupport::BaseQtVersion *version = QtSupport::QtKitAspect::qtVersion(target()->kit()); QtSupport::BaseQtVersion *version = QtSupport::QtKitAspect::qtVersion(target()->kit());
if (!version) // TODO: Add error message if (!version) {
qCDebug(deployStepLog,
"The Qt version for kit %s is not valid.",
qPrintable(target()->kit()->displayName()));
return false; return false;
}
m_androiddeployqtArgs = CommandLine(); m_androiddeployqtArgs = CommandLine();

2
src/plugins/android/androidpotentialkit.h
View File

@@ -51,7 +51,5 @@ private:
void recheck(); void recheck();
}; };
// TODO add "Download" links to the settings page?
} }
} }