feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Vcs: Provide default implementations for some pure methods

Browse Source 
Saves empty re-implementations in some cases.

Change-Id: I4ffa039d70257f2256942e09fcabe790943e1578
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2020-01-31 17:21:51 +01:00
parent 039e70c727
commit b1f5b18ac5
4 changed files with 3 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cvs/cvsplugin.cpp
View File

@@ -196,10 +196,6 @@ public:
});
}
QString findTopLevelForFile(const QFileInfo &) const override { return {}; }
QStringList revisionSpec(const QString &) const override { return {}; }
StatusItem parseStatusLine(const QString &) const override { return {}; }
ExitCodeInterpreter exitCodeInterpreter(VcsCommandTag cmd) const override
{
if (cmd == DiffCommand) {

18
src/plugins/subversion/subversionclient.cpp
View File

@@ -325,24 +325,6 @@ void SubversionClient::describe(const QString &workingDirectory, int changeNumbe
controller->requestReload();
}
QString SubversionClient::findTopLevelForFile(const QFileInfo &file) const
{
Q_UNUSED(file)
return QString();
}
QStringList SubversionClient::revisionSpec(const QString &revision) const
{
Q_UNUSED(revision)
return QStringList();
}
VcsBaseClient::StatusItem SubversionClient::parseStatusLine(const QString &line) const
{
Q_UNUSED(line)
return VcsBaseClient::StatusItem();
}
} // namespace Internal
} // namespace Subversion

3
src/plugins/subversion/subversionclient.h
View File

@@ -62,9 +62,6 @@ public:
bool enableAnnotationContextMenu = false) override;
void describe(const QString &workingDirectory, int changeNumber, const QString &title);
QString findTopLevelForFile(const QFileInfo &file) const override;
QStringList revisionSpec(const QString &revision) const override;
StatusItem parseStatusLine(const QString &line) const override;
// Add authorization options to the command line arguments.
static QStringList addAuthenticationOptions(const VcsBase::VcsBaseClientSettings &settings);

6
src/plugins/vcsbase/vcsbaseclient.h
View File

@@ -192,7 +192,7 @@ public:
const QString &commitMessageFile,
const QStringList &extraOptions = QStringList());
virtual QString findTopLevelForFile(const QFileInfo &file) const = 0;
virtual QString findTopLevelForFile(const QFileInfo &/*file*/) const { return {}; }
virtual void view(const QString &source, const QString &id,
const QStringList &extraOptions = QStringList());
@@ -226,13 +226,13 @@ protected:
virtual Core::Id vcsEditorKind(VcsCommandTag cmd) const = 0;
virtual Utils::ExitCodeInterpreter exitCodeInterpreter(VcsCommandTag cmd) const;
virtual QStringList revisionSpec(const QString &revision) const = 0;
virtual QStringList revisionSpec(const QString &/*revision*/) const { return {}; }
typedef std::function<VcsBaseEditorConfig *(QToolBar *)> ConfigCreator;
void setDiffConfigCreator(ConfigCreator creator);
void setLogConfigCreator(ConfigCreator creator);
virtual StatusItem parseStatusLine(const QString &line) const = 0;
virtual StatusItem parseStatusLine(const QString &/*line*/) const { return {}; }
QString vcsEditorTitle(const QString &vcsCmd, const QString &sourceId) const;