feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Vcs: Provide default implementations for some pure methods

Browse Source 
Saves empty re-implementations in some cases.

Change-Id: I4ffa039d70257f2256942e09fcabe790943e1578
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2020-01-31 17:21:51 +01:00
parent 039e70c727
commit b1f5b18ac5
4 changed files with 3 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/vcsbase/vcsbaseclient.h
View File

@@ -192,7 +192,7 @@ public:
const QString &commitMessageFile,
const QStringList &extraOptions = QStringList());
virtual QString findTopLevelForFile(const QFileInfo &file) const = 0;
virtual QString findTopLevelForFile(const QFileInfo &/*file*/) const { return {}; }
virtual void view(const QString &source, const QString &id,
const QStringList &extraOptions = QStringList());
@@ -226,13 +226,13 @@ protected:
virtual Core::Id vcsEditorKind(VcsCommandTag cmd) const = 0;
virtual Utils::ExitCodeInterpreter exitCodeInterpreter(VcsCommandTag cmd) const;
virtual QStringList revisionSpec(const QString &revision) const = 0;
virtual QStringList revisionSpec(const QString &/*revision*/) const { return {}; }
typedef std::function<VcsBaseEditorConfig *(QToolBar *)> ConfigCreator;
void setDiffConfigCreator(ConfigCreator creator);
void setLogConfigCreator(ConfigCreator creator);
virtual StatusItem parseStatusLine(const QString &line) const = 0;
virtual StatusItem parseStatusLine(const QString &/*line*/) const { return {}; }
QString vcsEditorTitle(const QString &vcsCmd, const QString &sourceId) const;