feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Fix gathering failed Qt based tests

Browse Source 
Omit special and test data functions while collecting
as these cannot be addressed at all.

Change-Id: I3d79192cd07b4e7e2e76f04dfad36ef033593e71
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2021-08-16 12:36:01 +02:00
parent 3c0b75f2ef
commit b489afd91b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/autotest/qtest/qttesttreeitem.cpp
View File

@@ -226,7 +226,7 @@ static void collectFailedTestInfo(TestTreeItem *item, QList<ITestConfiguration *
QTC_ASSERT(item->type() == TestTreeItem::TestCase, return); QTC_ASSERT(item->type() == TestTreeItem::TestCase, return);
QStringList testCases; QStringList testCases;
item->forFirstLevelChildren([&testCases](ITestTreeItem *func) { item->forFirstLevelChildren([&testCases](ITestTreeItem *func) {
if (func->data(0, FailedRole).toBool()) { if (func->type() == TestTreeItem::TestFunction && func->data(0, FailedRole).toBool()) {
testCases << func->name(); testCases << func->name();
} else { } else {
func->forFirstLevelChildren([&testCases, func](ITestTreeItem *dataTag) { func->forFirstLevelChildren([&testCases, func](ITestTreeItem *dataTag) {

2
src/plugins/autotest/quick/quicktesttreeitem.cpp
View File

@@ -271,7 +271,7 @@ QList<ITestConfiguration *> QuickTestTreeItem::getSelectedTestConfigurations() c
QList<ITestConfiguration *> QuickTestTreeItem::getFailedTestConfigurations() const QList<ITestConfiguration *> QuickTestTreeItem::getFailedTestConfigurations() const
{ {
return testConfigurationsFor(this, [](TestTreeItem *it) { return testConfigurationsFor(this, [](TestTreeItem *it) {
return it->data(0, FailedRole).toBool(); return it->data(0, FailedRole).toBool() && it->type() == TestTreeItem::TestFunction;
}); });
} }