feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Remove one copied member when direct access is ok

Browse Source 
Change-Id: I2813d062781571b50ae89e6f0482a4e72419ccde
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
hjk
2023-07-25 10:44:44 +02:00
parent 846ff37aac
commit b53d1186ea
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/valgrind/suppressiondialog.cpp
View File

@@ -93,7 +93,6 @@ static bool equalSuppression(const Error &error, const Error &suppressed)
SuppressionDialog::SuppressionDialog(MemcheckErrorView *view, const QList<Error> &errors) SuppressionDialog::SuppressionDialog(MemcheckErrorView *view, const QList<Error> &errors)
: m_view(view), : m_view(view),
m_settings(view->settings()),
m_cleanupIfCanceled(false), m_cleanupIfCanceled(false),
m_errors(errors), m_errors(errors),
m_fileChooser(new PathChooser(this)), m_fileChooser(new PathChooser(this)),
@@ -191,7 +190,7 @@ void SuppressionDialog::accept()
} }
} }
m_settings->suppressions.addSuppressionFile(path); m_view->settings()->suppressions.addSuppressionFile(path);
const QModelIndexList indices = Utils::sorted(m_view->selectionModel()->selectedRows(), const QModelIndexList indices = Utils::sorted(m_view->selectionModel()->selectedRows(),
[](const QModelIndex &l, const QModelIndex &r) { [](const QModelIndex &l, const QModelIndex &r) {

2
src/plugins/valgrind/suppressiondialog.h
View File

@@ -18,7 +18,6 @@ namespace Valgrind {
namespace Internal { namespace Internal {
class MemcheckErrorView; class MemcheckErrorView;
class ValgrindBaseSettings;
class SuppressionDialog : public QDialog class SuppressionDialog : public QDialog
{ {
@@ -33,7 +32,6 @@ private:
void reject() override; void reject() override;
MemcheckErrorView *m_view; MemcheckErrorView *m_view;
ValgrindBaseSettings *m_settings;
bool m_cleanupIfCanceled; bool m_cleanupIfCanceled;
QList<XmlProtocol::Error> m_errors; QList<XmlProtocol::Error> m_errors;