feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LSP: Fix and simplify log size restriction logic

Browse Source 
Do not subtract from unsigned (size) values.
Amends d15d15efa2.

Change-Id: I9a8b09d3733b49ea646ae8a14caefcf5c908fad3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2020-06-19 15:52:29 +02:00
parent 8cb74f88f9
commit b7862ae453
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/languageclient/lsplogger.cpp
View File

@@ -94,10 +94,10 @@ void LspLogger::log(const LspLogMessage::MessageSender sender,
const BaseMessage &message) const BaseMessage &message)
{ {
std::list<LspLogMessage> &clientLog = m_logs[clientName]; std::list<LspLogMessage> &clientLog = m_logs[clientName];
for (auto delta = clientLog.size() - m_logSize + 1; delta > 0; --delta) while (clientLog.size() >= m_logSize)
clientLog.pop_front(); clientLog.pop_front();
m_logs[clientName].push_back({sender, QTime::currentTime(), message}); clientLog.push_back({sender, QTime::currentTime(), message});
emit newMessage(clientName, m_logs[clientName].back()); emit newMessage(clientName, clientLog.back());
} }
std::list<LspLogMessage> LspLogger::messages(const QString &clientName) const std::list<LspLogMessage> LspLogger::messages(const QString &clientName) const