feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

EditorManager: Fix timing of aboutToSave signal

Browse Source 
"Save as" sent it before even the new name was asked.

Change-Id: I8f791689267e57e63d51990af96373f653e54943
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Eike Ziller
2016-11-03 11:32:12 +01:00
parent 5992c74488
commit b93fe5a49e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/coreplugin/editormanager/editormanager.cpp
View File

@@ -2100,7 +2100,6 @@ bool EditorManagerPrivate::saveDocumentAs(IDocument *document)
if (!document) if (!document)
return false; return false;
emit m_instance->aboutToSave(document);
Utils::MimeDatabase mdb; Utils::MimeDatabase mdb;
const QString filter = Utils::MimeDatabase::allFiltersString(); const QString filter = Utils::MimeDatabase::allFiltersString();
QString selectedFilter; QString selectedFilter;
@@ -2130,6 +2129,7 @@ bool EditorManagerPrivate::saveDocumentAs(IDocument *document)
EditorManager::closeDocuments(QList<IDocument *>() << otherDocument, false); EditorManager::closeDocuments(QList<IDocument *>() << otherDocument, false);
} }
emit m_instance->aboutToSave(document);
const bool success = DocumentManager::saveDocument(document, absoluteFilePath); const bool success = DocumentManager::saveDocument(document, absoluteFilePath);
document->checkPermissions(); document->checkPermissions();