feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CustomToolChainConfigWidget: Avoid using sender()

Browse Source 
Change-Id: Ic678d0f1edee7e5a36c9d3a1c467830a5325bd07
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-07-20 16:28:40 +02:00
parent 180116fdf1
commit bb0030e907
2 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/projectexplorer/customtoolchain.cpp
View File

@@ -427,9 +427,9 @@ CustomToolChainConfigWidget::CustomToolChainConfigWidget(CustomToolChain *tc) :
connect(m_makeCommand, &PathChooser::rawPathChanged, this, &ToolChainConfigWidget::dirty); connect(m_makeCommand, &PathChooser::rawPathChanged, this, &ToolChainConfigWidget::dirty);
connect(m_abiWidget, &AbiWidget::abiChanged, this, &ToolChainConfigWidget::dirty); connect(m_abiWidget, &AbiWidget::abiChanged, this, &ToolChainConfigWidget::dirty);
connect(m_predefinedMacros, &QPlainTextEdit::textChanged, connect(m_predefinedMacros, &QPlainTextEdit::textChanged,
this, &CustomToolChainConfigWidget::updateSummaries); this, [this] { updateSummaries(m_predefinedDetails); });
connect(m_headerPaths, &QPlainTextEdit::textChanged, connect(m_headerPaths, &QPlainTextEdit::textChanged,
this, &CustomToolChainConfigWidget::updateSummaries); this, [this] { updateSummaries(m_headerDetails); });
connect(m_cxx11Flags, &QLineEdit::textChanged, this, &ToolChainConfigWidget::dirty); connect(m_cxx11Flags, &QLineEdit::textChanged, this, &ToolChainConfigWidget::dirty);
connect(m_mkspecs, &QLineEdit::textChanged, this, &ToolChainConfigWidget::dirty); connect(m_mkspecs, &QLineEdit::textChanged, this, &ToolChainConfigWidget::dirty);
connect(m_errorParserComboBox, &QComboBox::currentIndexChanged, connect(m_errorParserComboBox, &QComboBox::currentIndexChanged,
@@ -437,12 +437,9 @@ CustomToolChainConfigWidget::CustomToolChainConfigWidget(CustomToolChain *tc) :
errorParserChanged(); errorParserChanged();
} }
void CustomToolChainConfigWidget::updateSummaries() void CustomToolChainConfigWidget::updateSummaries(TextEditDetailsWidget *detailsWidget)
{ {
if (sender() == m_predefinedMacros) detailsWidget->updateSummaryText();
m_predefinedDetails->updateSummaryText();
else
m_headerDetails->updateSummaryText();
emit dirty(); emit dirty();
} }

2
src/plugins/projectexplorer/customtoolchain.h
View File

@@ -141,7 +141,7 @@ public:
CustomToolChainConfigWidget(CustomToolChain *); CustomToolChainConfigWidget(CustomToolChain *);
private: private:
void updateSummaries(); void updateSummaries(TextEditDetailsWidget *detailsWidget);
void errorParserChanged(int index = -1); void errorParserChanged(int index = -1);
protected: protected: