feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Use GetOffsetByName for staticMetaObject lookup

Browse Source 
Halves the lookup time compared to parse and evaluate.

Change-Id: I8beda23f444c73816a93e38154d2ca502b701fe8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2017-02-01 12:14:06 +01:00
parent 1b5d8a84f8
commit bb76740691
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
share/qtcreator/debugger/cdbbridge.py
View File

@@ -421,7 +421,7 @@ class Dumper(DumperBase):
return mem
def findStaticMetaObject(self, typeName):
ptr = self.findValueByExpression('&' + typeName + '::staticMetaObject')
ptr = cdbext.getAddressByName(typeName + '::staticMetaObject')
return ptr
def warn(self, msg):

16
src/libs/qtcreatorcdbext/pycdbextmodule.cpp
View File

@@ -166,6 +166,20 @@ static PyObject *cdbext_getNameByAddress(PyObject *, PyObject *args)
return ret;
}
static PyObject *cdbext_getAddressByName(PyObject *, PyObject *args)
{
char *name = 0;
if (!PyArg_ParseTuple(args, "s", &name))
Py_RETURN_NONE;
CIDebugSymbols *symbols = ExtensionCommandContext::instance()->symbols();
ULONG64 address = 0;
if (FAILED(symbols->GetOffsetByName(name, &address)))
address = 0;
return Py_BuildValue("K", address);
}
static PyObject *cdbext_lookupType(PyObject *, PyObject *args) // -> Type
{
char *type;
@@ -364,6 +378,8 @@ static PyMethodDef cdbextMethods[] = {
"Returns a list of symbol names matching the given pattern"},
{"getNameByAddress", cdbext_getNameByAddress, METH_VARARGS,
"Returns the name of the symbol at the given address"},
{"getAddressByName", cdbext_getAddressByName, METH_VARARGS,
"Returns the address of the symbol with the given name"},
{"lookupType", cdbext_lookupType, METH_VARARGS,
"Returns type object or None if the type can not be resolved"},
{"listOfLocals", cdbext_listOfLocals, METH_VARARGS,