feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

debugger: don't stop at disabled breakpoints in script engine

Browse Source
This commit is contained in:
hjk
2010-07-07 13:26:32 +02:00
parent c40521b12c
commit bcd2146db1
2 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/debugger/breakhandler.cpp
View File

@@ -742,14 +742,14 @@ bool BreakHandler::setData(const QModelIndex &index, const QVariant &value, int
case BreakpointEnabledRole:
if (data->enabled != value.toBool()) {
toggleBreakpointEnabled(data);
layoutChanged();
emit layoutChanged();
}
return true;
case BreakpointUseFullPathRole:
if (data->useFullPath != value.toBool()) {
data->useFullPath = value.toBool();
layoutChanged();
emit layoutChanged();
}
return true;
@@ -757,21 +757,21 @@ bool BreakHandler::setData(const QModelIndex &index, const QVariant &value, int
QString val = value.toString();
if (data->funcName != val) {
data->funcName = val;
layoutChanged();
emit layoutChanged();
}
return true;
QString val = value.toString();
if (data->fileName != val) {
data->fileName = val;
layoutChanged();
emit layoutChanged();
}
return true;
QByteArray val = value.toString().toLatin1();
if (data->lineNumber != val) {
data->lineNumber = val;
layoutChanged();
emit layoutChanged();
}
return true;
*/
@@ -779,7 +779,7 @@ bool BreakHandler::setData(const QModelIndex &index, const QVariant &value, int
QByteArray val = value.toString().toLatin1();
if (val != data->condition) {
data->condition = val;
layoutChanged();
emit layoutChanged();
}
}
return true;
@@ -788,7 +788,7 @@ bool BreakHandler::setData(const QModelIndex &index, const QVariant &value, int
QByteArray val = value.toString().toLatin1();
if (val != data->ignoreCount) {
data->ignoreCount = val;
layoutChanged();
emit layoutChanged();
}
}
return true;
@@ -797,7 +797,7 @@ bool BreakHandler::setData(const QModelIndex &index, const QVariant &value, int
QByteArray val = value.toString().toLatin1();
if (val != data->threadSpec) {
data->threadSpec = val;
layoutChanged();
emit layoutChanged();
}
}
return true;

12
src/plugins/debugger/script/scriptengine.cpp
View File

@@ -595,8 +595,10 @@ bool ScriptEngine::checkForBreakCondition(bool byFunction)
// Update breakpoints
const QString functionName = info.functionName();
const QString fileName = info.fileName();
const int lineNumber = byFunction? info.functionStartLineNumber() : info.lineNumber();
SDEBUG("checkForBreakCondition" << byFunction << functionName << lineNumber << fileName);
const int lineNumber = byFunction
? info.functionStartLineNumber() : info.lineNumber();
SDEBUG("checkForBreakCondition" << byFunction << functionName
<< lineNumber << fileName);
if (m_stopOnNextLine) {
// Interrupt inferior
m_stopOnNextLine = false;
@@ -609,7 +611,11 @@ bool ScriptEngine::checkForBreakCondition(bool byFunction)
if (!data)
return false;
// we just run into a breakpoint
// Skip disabled breakpoint.
if (!data->enabled)
return false;
// We just run into a breakpoint.
//SDEBUG("RESOLVING BREAKPOINT AT " << fileName << lineNumber);
data->bpLineNumber = QByteArray::number(lineNumber);
data->bpFileName = fileName;