feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Gerrit: Remove method that is used only once

Browse Source 
Change-Id: I6a65cf7dcb2e5e0f0cff46fd11092799254023be
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Tobias Hunger
2015-06-10 10:02:44 +02:00
parent 29b96af1cb
commit be0aa40520
2 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/git/gerrit/gerritplugin.cpp
View File

@@ -397,14 +397,6 @@ void GerritPlugin::push()
push(GitPlugin::instance()->currentState().topLevel());
}
Utils::FileName GerritPlugin::gitBinary()
{
const Utils::FileName git = gitClient()->vcsBinary();
if (git.isEmpty())
VcsBase::VcsOutputWindow::appendError(tr("Git is not available."));
return git;
}
Utils::FileName GerritPlugin::gitBinDirectory()
{
return gitClient()->gitBinDirectory();
@@ -434,9 +426,11 @@ void GerritPlugin::fetchCheckout(const QSharedPointer<GerritChange> &change)
void GerritPlugin::fetch(const QSharedPointer<GerritChange> &change, int mode)
{
// Locate git.
const Utils::FileName git = gitBinary();
if (git.isEmpty())
const Utils::FileName git = gitClient()->vcsBinary();
if (git.isEmpty()) {
VcsBase::VcsOutputWindow::appendError(tr("Git is not available."));
return;
}
GitClient *client = gitClient();

1
src/plugins/git/gerrit/gerritplugin.h
View File

@@ -64,7 +64,6 @@ public:
bool initialize(Core::ActionContainer *ac);
static Utils::FileName gitBinary();
static Utils::FileName gitBinDirectory();
static QString branch(const QString &repository);
void addToLocator(Core::CommandLocator *locator);