feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: Replace FIXME comments with links to bug reports

Browse Source 
Change-Id: Ib6520781e88b8dcf63dd553e199939ff65ae1f05
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2021-09-29 16:35:52 +02:00
parent c30bfde80c
commit be3dd751cb
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/clangcodemodel/test/clangdtests.cpp
View File

@@ -1627,7 +1627,7 @@ void ClangdTestCompletion::testFunctionHintsFiltered()
QVERIFY(proposal); QVERIFY(proposal);
QCOMPARE(proposal->size(), 2); QCOMPARE(proposal->size(), 2);
QVERIFY(hasItem(proposal, "func(const S &amp;s, <b>int j</b>) -&gt; void")); QVERIFY(hasItem(proposal, "func(const S &amp;s, <b>int j</b>) -&gt; void"));
QEXPECT_FAIL("", "FIXME: LanguageClient handles active parameter only in active signature", Abort); QEXPECT_FAIL("", "QTCREATORBUG-26346", Abort);
QVERIFY(hasItem(proposal, "func(const S &amp;s, <b>int j</b>, int k) -&gt; void")); QVERIFY(hasItem(proposal, "func(const S &amp;s, <b>int j</b>, int k) -&gt; void"));
} }
@@ -1640,7 +1640,7 @@ void ClangdTestCompletion::testFunctionHintConstructor()
QVERIFY(!hasItem(proposal, "globalVariable")); QVERIFY(!hasItem(proposal, "globalVariable"));
QVERIFY(!hasItem(proposal, " class")); QVERIFY(!hasItem(proposal, " class"));
QVERIFY(hasItem(proposal, "Foo(<b>int</b>)")); QVERIFY(hasItem(proposal, "Foo(<b>int</b>)"));
QEXPECT_FAIL("", "FIXME: LanguageClient handles active parameter only in active signature", Abort); QEXPECT_FAIL("", "QTCREATORBUG-26346", Abort);
QVERIFY(hasItem(proposal, "Foo(<b>int</b>, double)")); QVERIFY(hasItem(proposal, "Foo(<b>int</b>, double)"));
} }
@@ -1669,8 +1669,7 @@ void ClangdTestCompletion::testCompletePrivateFunctionDefinition()
getProposal("privateFuncDefCompletion.cpp", proposal); getProposal("privateFuncDefCompletion.cpp", proposal);
QVERIFY(proposal); QVERIFY(proposal);
QEXPECT_FAIL("", "FIXME: clangd needs to differentiate " QEXPECT_FAIL("", "https://github.com/clangd/clangd/issues/880", Abort);
"between function call and function definiton", Abort);
QCOMPARE(proposal->size(), 1); QCOMPARE(proposal->size(), 1);
QVERIFY(hasItem(proposal, " theFunc()")); QVERIFY(hasItem(proposal, " theFunc()"));
} }