feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: Replace TODO items with links to upstream bug reports

Browse Source 
Change-Id: Iff1ccf77aca74bc34e2944996e7ef2eb2fcb3bad
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2021-09-24 14:10:30 +02:00
parent a73338e188
commit be6ea67bfd
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/clangcodemodel/clangdclient.cpp
View File

@@ -2187,7 +2187,7 @@ static void collectExtraResults(QFutureInterface<TextEditor::HighlightingResult>
// the closing angle brackets, then the inner TemplateSpecialization node's range // the closing angle brackets, then the inner TemplateSpecialization node's range
// will extend one character too far, covering the outer's closing angle bracket. // will extend one character too far, covering the outer's closing angle bracket.
// This is what we are correcting for here. // This is what we are correcting for here.
// TODO: Can we fix this in clang? // This issue is tracked at https://github.com/clangd/clangd/issues/871.
if (searchStart2 == searchEnd2) if (searchStart2 == searchEnd2)
--searchStart2; --searchStart2;
insertAngleBracketInfo(nodeStartPos, posForNodeStart(children.at(1)), insertAngleBracketInfo(nodeStartPos, posForNodeStart(children.at(1)),
@@ -2451,8 +2451,8 @@ static void semanticHighlighter(QFutureInterface<TextEditor::HighlightingResult>
const AstNode node = path.at(path.length() - 2); const AstNode node = path.at(path.length() - 2);
if (node.kind() == "CXXDestructor" && !node.arcanaContains("implicit")) { if (node.kind() == "CXXDestructor" && !node.arcanaContains("implicit")) {
styles.mainStyle = TextEditor::C_FUNCTION; styles.mainStyle = TextEditor::C_FUNCTION;
// TODO: "declaration" modifier is missing for destructors; fix in clangd
// (the scope is also wrong) // https://github.com/clangd/clangd/issues/872
if (node.role() == "declaration") if (node.role() == "declaration")
styles.mixinStyles.push_back(TextEditor::C_DECLARATION); styles.mixinStyles.push_back(TextEditor::C_DECLARATION);
} }