feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake/Qbs: Do not emit Project::fileListChanged()

Browse Source 
...explicitly.
This is already done as part of Project::setRootProjectNode(), and the
signal is connected to some rather expensive operations.

Task-number: QTCREATORBUG-18533
Change-Id: I96ea2f49c866f2b60f599748c4d5b82c790ed2ca
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2020-02-05 14:54:26 +01:00
parent 11c242427c
commit beed0c7396
2 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
View File

@@ -481,8 +481,6 @@ void CMakeBuildSystem::updateProjectData()
updateQmlJSCodeModel(); updateQmlJSCodeModel();
} }
emit p->fileListChanged();
emit m_buildConfiguration->emitBuildTypeChanged(); emit m_buildConfiguration->emitBuildTypeChanged();
m_buildDirManager.resetData(); m_buildDirManager.resetData();

1
src/plugins/qbsprojectmanager/qbsproject.cpp
View File

@@ -463,7 +463,6 @@ void QbsBuildSystem::updateAfterParse()
updateCppCodeModel(); updateCppCodeModel();
updateExtraCompilers(); updateExtraCompilers();
updateQmlJsCodeModel(); updateQmlJsCodeModel();
emit project()->fileListChanged();
m_envCache.clear(); m_envCache.clear();
m_guard.markAsSuccess(); m_guard.markAsSuccess();
m_guard = {}; m_guard = {};