feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Save a few cycles in updateFromSettings()

Browse Source 
Makes it easier to debug, too.

Change-Id: Id55591195bc645cfff002d04e4fdae6e4b3a4b85
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
hjk
2023-07-24 17:33:16 +02:00
parent d22df34e6c
commit c007be8a9a
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/valgrind/memchecktool.cpp
View File

@@ -909,14 +909,17 @@ void MemcheckToolPrivate::settingsDestroyed(QObject *settings)
void MemcheckToolPrivate::updateFromSettings() void MemcheckToolPrivate::updateFromSettings()
{ {
const QList<int> stored = m_settings->visibleErrorKinds();
for (QAction *action : std::as_const(m_errorFilterActions)) { for (QAction *action : std::as_const(m_errorFilterActions)) {
bool contained = true; bool contained = true;
const QList<QVariant> actions = action->data().toList(); const QList<QVariant> actions = action->data().toList();
for (const QVariant &v : actions) { for (const QVariant &v : actions) {
bool ok; bool ok;
int kind = v.toInt(&ok); int kind = v.toInt(&ok);
if (ok && !m_settings->visibleErrorKinds().contains(kind)) if (ok && !stored.contains(kind)) {
contained = false; contained = false;
break;
}
} }
action->setChecked(contained); action->setChecked(contained);
} }