feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AnalyerRunControl: Don't store the runconfiguration

Browse Source 
There is no gurantee that the runconfiguration stays alive after
creation.

Change-Id: Ia520cc33a89ec56ad6a9b928f841eb4551732ae0
Reviewed-by: hjk <hjk@theqtcompany.com>
This commit is contained in:
Daniel Teske
2015-06-15 12:39:19 +02:00
committed by hjk
parent 1538dca81a
commit c209eb9fbb
2 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/analyzerbase/analyzerruncontrol.cpp
View File

@@ -53,7 +53,6 @@ AnalyzerRunControl::AnalyzerRunControl(const AnalyzerStartParameters &sp,
{ {
setIcon(QLatin1String(":/images/analyzer_start_small.png")); setIcon(QLatin1String(":/images/analyzer_start_small.png"));
m_runConfig = runConfiguration;
m_sp = sp; m_sp = sp;
connect(this, &AnalyzerRunControl::finished, connect(this, &AnalyzerRunControl::finished,
@@ -101,7 +100,7 @@ bool AnalyzerRunControl::isRunning() const
QString AnalyzerRunControl::displayName() const QString AnalyzerRunControl::displayName() const
{ {
return m_runConfig ? m_runConfig->displayName() : m_sp.displayName; return m_sp.displayName;
} }
} // namespace Analyzer } // namespace Analyzer

5
src/plugins/analyzerbase/analyzerruncontrol.h
View File

@@ -68,9 +68,6 @@ public:
virtual void pause() {} virtual void pause() {}
virtual void unpause() {} virtual void unpause() {}
/// The active run configuration for this engine, might be zero.
ProjectExplorer::RunConfiguration *runConfiguration() const { return m_runConfig; }
/// The start parameters for this engine. /// The start parameters for this engine.
const AnalyzerStartParameters &startParameters() const { return m_sp; } const AnalyzerStartParameters &startParameters() const { return m_sp; }
@@ -98,8 +95,6 @@ signals:
private: private:
bool supportsReRunning() const { return false; } bool supportsReRunning() const { return false; }
ProjectExplorer::RunConfiguration *m_runConfig;
AnalyzerStartParameters m_sp; AnalyzerStartParameters m_sp;
}; };
} // namespace Analyzer } // namespace Analyzer