feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove QTC_CHECK in BuildStep::buildConfiguration()

Browse Source 
This keeps hitting us on all kinds of valid deployment-related code
paths, resulting in silly workarounds that do not solve an actual
problem.

Change-Id: I5c728f91f1138fa833c6fc9ab19595060a88e19d
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2020-11-18 12:41:14 +01:00
parent ab99cd8882
commit c247024273
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/projectexplorer/buildstep.cpp
View File

@@ -212,12 +212,6 @@ BuildConfiguration *BuildStep::buildConfiguration() const
if (config) if (config)
return config; return config;
// This situation should be avoided, as the step returned below is almost
// always not the right one, but the fallback is best we can do.
// A potential currently still valid path is accessing a build configuration
// from a BuildStep in a DeployConfiguration. Let's hunt those down and
// replace with explicit code there.
QTC_CHECK(false);
// step is not part of a build configuration, use active build configuration of step's target // step is not part of a build configuration, use active build configuration of step's target
return target()->activeBuildConfiguration(); return target()->activeBuildConfiguration();
} }