feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LanguageClient: Do not cancel search on empty result list

Browse Source 
... for a rename request.
Instead, simply finish the search normally, leading to a "no matches
found" message rather than the misleading "search canceled".
But do cancel the search on an actual error.

Change-Id: I10401466bb4d81d53d26b8dc08bfed91db86cd5a
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2022-09-20 12:43:51 +02:00
parent ccfd472a8c
commit c2937f609e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/languageclient/languageclientsymbolsupport.cpp
View File

@@ -384,7 +384,7 @@ void SymbolSupport::handleRenameResponse(Core::SearchResult *search,
search->setSearchAgainEnabled(false); search->setSearchAgainEnabled(false);
search->finishSearch(false); search->finishSearch(false);
} else { } else {
search->finishSearch(true); search->finishSearch(error.has_value());
} }
} }