feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: directly use default value if settingsKey is not defined

Browse Source 
This saves one value > variant > value transformation.

Change-Id: I16e5c464017fdcc0b9a07b895bbe90423022ac83
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
David Schulz
2021-03-24 14:44:09 +01:00
parent baa794a7ba
commit c3ab90e30f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/utils/aspects.cpp
View File

@@ -506,8 +506,8 @@ void BaseAspect::readSettings(const QSettings *settings)
{ {
if (settingsKey().isEmpty()) if (settingsKey().isEmpty())
return; return;
const QVariant val = settings->value(settingsKey(), toSettingsValue(defaultValue())); const QVariant &val = settings->value(settingsKey());
setValue(fromSettingsValue(val)); setValue(val.isValid() ? fromSettingsValue(val) : defaultValue());
} }
void BaseAspect::writeSettings(QSettings *settings) const void BaseAspect::writeSettings(QSettings *settings) const