feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Unmark the reflection flage for valid Qml property changes

Browse Source 
The reflection flag is unmarked for valid Qml property changes in order
to be updated in the puppet side.

Task-number: QDS-9881
Change-Id: Ibd36fb1ee844f08efa256d28514a3f0debd467e2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Ali Kianian
2023-06-27 10:09:54 +03:00
parent fb9a7e2d3a
commit c3dee68573
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp
View File

@@ -1307,17 +1307,20 @@ ChangeValuesCommand NodeInstanceView::createChangeValueCommand(const QList<Varia
{ {
QVector<PropertyValueContainer> containerList; QVector<PropertyValueContainer> containerList;
const bool reflectionFlag = m_puppetTransaction.isValid() && (!currentTimeline().isValid() || !currentTimeline().isRecording()); bool reflectionFlag = m_puppetTransaction.isValid()
&& (!currentTimeline().isValid() || !currentTimeline().isRecording());
for (const VariantProperty &property : propertyList) { for (const VariantProperty &property : propertyList) {
ModelNode node = property.parentModelNode(); ModelNode node = property.parentModelNode();
if (QmlPropertyChanges::isValidQmlPropertyChanges(node))
reflectionFlag = false;
if (node.isValid() && hasInstanceForModelNode(node)) { if (node.isValid() && hasInstanceForModelNode(node)) {
NodeInstance instance = instanceForModelNode(node); NodeInstance instance = instanceForModelNode(node);
PropertyValueContainer container(instance.instanceId(), property.name(), property.value(), property.dynamicTypeName()); PropertyValueContainer container(instance.instanceId(), property.name(), property.value(), property.dynamicTypeName());
container.setReflectionFlag(reflectionFlag); container.setReflectionFlag(reflectionFlag);
containerList.append(container); containerList.append(container);
} }
} }
return ChangeValuesCommand(containerList); return ChangeValuesCommand(containerList);