feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Postpone set up of kit save connection

Browse Source 
Does not require early access to ICore::instance(), and there's
no point in attempting to save kits before they werde set up.

Change-Id: I68953c6019e14e88655ddb46b30ebb9f1916ec46
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
hjk
2023-08-16 08:20:31 +02:00
parent f21282cb2d
commit c40a802e70
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/projectexplorer/kitmanager.cpp
View File

@@ -134,8 +134,6 @@ KitManager::KitManager()
{ {
d = new KitManagerPrivate; d = new KitManagerPrivate;
connect(ICore::instance(), &ICore::saveSettingsRequested, this, &KitManager::saveKits);
connect(this, &KitManager::kitAdded, this, &KitManager::kitsChanged); connect(this, &KitManager::kitAdded, this, &KitManager::kitsChanged);
connect(this, &KitManager::kitRemoved, this, &KitManager::kitsChanged); connect(this, &KitManager::kitRemoved, this, &KitManager::kitsChanged);
connect(this, &KitManager::kitUpdated, this, &KitManager::kitsChanged); connect(this, &KitManager::kitUpdated, this, &KitManager::kitsChanged);
@@ -151,6 +149,8 @@ void KitManager::restoreKits()
{ {
QTC_ASSERT(!d->m_initialized, return ); QTC_ASSERT(!d->m_initialized, return );
connect(ICore::instance(), &ICore::saveSettingsRequested, &KitManager::saveKits);
std::vector<std::unique_ptr<Kit>> resultList; std::vector<std::unique_ptr<Kit>> resultList;
// read all kits from user file // read all kits from user file