feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify SessionManager::markSessionFileDirty(bool)

Browse Source 
It did nothing if false was passed. So do not call it in that
case and drop the parameter.

Change-Id: I9b055cb0c0c8be85d528247a269fb7fea062326b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2018-05-25 17:06:42 +02:00
parent 8416a14f3d
commit c43100c601
2 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/projectexplorer/session.cpp
View File

@@ -140,9 +140,9 @@ SessionManager::SessionManager(QObject *parent) : QObject(parent)
connect(this, &SessionManager::projectDisplayNameChanged, connect(this, &SessionManager::projectDisplayNameChanged,
EditorManager::instance(), &EditorManager::updateWindowTitles); EditorManager::instance(), &EditorManager::updateWindowTitles);
connect(EditorManager::instance(), &EditorManager::editorOpened, connect(EditorManager::instance(), &EditorManager::editorOpened,
this, [] { markSessionFileDirty(); }); this, &SessionManager::markSessionFileDirty);
connect(EditorManager::instance(), &EditorManager::editorsClosed, connect(EditorManager::instance(), &EditorManager::editorsClosed,
this, [] { markSessionFileDirty(); }); this, &SessionManager::markSessionFileDirty);
EditorManager::setWindowTitleAdditionHandler(&SessionManagerPrivate::windowTitleAddition); EditorManager::setWindowTitleAdditionHandler(&SessionManagerPrivate::windowTitleAddition);
EditorManager::setSessionTitleHandler(&SessionManagerPrivate::sessionTitle); EditorManager::setSessionTitleHandler(&SessionManagerPrivate::sessionTitle);
@@ -719,7 +719,6 @@ void SessionManager::setValue(const QString &name, const QVariant &value)
if (d->m_values.value(name) == value) if (d->m_values.value(name) == value)
return; return;
d->m_values.insert(name, value); d->m_values.insert(name, value);
markSessionFileDirty(false);
} }
QVariant SessionManager::value(const QString &name) QVariant SessionManager::value(const QString &name)
@@ -1052,9 +1051,8 @@ void SessionManager::reportProjectLoadingProgress()
d->sessionLoadingProgress(); d->sessionLoadingProgress();
} }
void SessionManager::markSessionFileDirty(bool makeDefaultVirginDirty) void SessionManager::markSessionFileDirty()
{ {
if (makeDefaultVirginDirty)
d->m_virginSession = false; d->m_virginSession = false;
} }

2
src/plugins/projectexplorer/session.h
View File

@@ -136,7 +136,7 @@ signals: // for tests only
private: private:
static void saveActiveMode(Core::Id mode); static void saveActiveMode(Core::Id mode);
static void configureEditor(Core::IEditor *editor, const QString &fileName); static void configureEditor(Core::IEditor *editor, const QString &fileName);
static void markSessionFileDirty(bool makeDefaultVirginDirty = true); static void markSessionFileDirty();
static void configureEditors(Project *project); static void configureEditors(Project *project);
}; };