feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Add missing "const" and "&" in range-basd for loops

Browse Source 
Change-Id: I93821f97fb1d8c3154bc03b8f54c504a6f712269
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
This commit is contained in:
Alessandro Portale
2021-02-17 23:26:19 +01:00
parent e2dd9639e5
commit c697b503e9
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qmldesigner/components/connectioneditor/bindingmodel.cpp
View File

@@ -195,12 +195,12 @@ QStringList BindingModel::possibleSourceProperties(const BindingProperty &bindin
NodeMetaInfo metaInfo = modelNode.metaInfo();
for (VariantProperty variantProperty : modelNode.variantProperties()) {
for (const VariantProperty &variantProperty : modelNode.variantProperties()) {
if (variantProperty.isDynamic())
possibleProperties << QString::fromUtf8(variantProperty.name());
}
for (BindingProperty bindingProperty : modelNode.bindingProperties()) {
for (const BindingProperty &bindingProperty : modelNode.bindingProperties()) {
if (bindingProperty.isDynamic())
possibleProperties << QString::fromUtf8((bindingProperty.name()));
}

4
src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimportdialog.cpp
View File

@@ -294,10 +294,10 @@ void ItemLibraryAssetImportDialog::createTab(const QString &tabLabel, int option
widgets.append(QVector<QPair<QWidget *, QWidget *>>());
for (const auto group : groups) {
for (const auto &group : groups) {
const QString name = group.toObject().value("name").toString();
const QJsonArray items = group.toObject().value("items").toArray();
for (const auto item : items)
for (const auto &item : items)
optionToGroupMap.insert(item.toString(), name);
auto groupLabel = new QLabel(name, optionsAreaContents);
QFont labelFont = groupLabel->font();

2
src/plugins/qmldesigner/components/propertyeditor/propertyeditorcontextobject.cpp
View File

@@ -283,7 +283,7 @@ void PropertyEditorContextObject::changeTypeName(const QString &typeName)
if (msgBox.exec() == QMessageBox::Cancel)
return;
for (auto p : qAsConst(incompatibleProperties))
for (const auto &p : qAsConst(incompatibleProperties))
selectedNode.removeProperty(p);
}