feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Help: Remove trivial slots

Browse Source 
Use one-line lambdas

Change-Id: I85d1fe33283b6c517a1942d833d6b127002540f5
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Eike Ziller
2017-07-12 14:33:18 +02:00
parent 2eb83100ff
commit c8affd6e74
2 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/plugins/help/helpplugin.cpp
View File

@@ -200,12 +200,16 @@ bool HelpPlugin::initialize(const QStringList &arguments, QString *error)
action = new QAction(tr("Technical Support"), this); action = new QAction(tr("Technical Support"), this);
cmd = ActionManager::registerAction(action, "Help.TechSupport"); cmd = ActionManager::registerAction(action, "Help.TechSupport");
ActionManager::actionContainer(Core::Constants::M_HELP)->addAction(cmd, Core::Constants::G_HELP_SUPPORT); ActionManager::actionContainer(Core::Constants::M_HELP)->addAction(cmd, Core::Constants::G_HELP_SUPPORT);
connect(action, &QAction::triggered, this, &HelpPlugin::slotOpenSupportPage); connect(action, &QAction::triggered, this, [this] {
showLinkInHelpMode(QUrl("qthelp://org.qt-project.qtcreator/doc/technical-support.html"));
});
action = new QAction(tr("Report Bug..."), this); action = new QAction(tr("Report Bug..."), this);
cmd = ActionManager::registerAction(action, "Help.ReportBug"); cmd = ActionManager::registerAction(action, "Help.ReportBug");
ActionManager::actionContainer(Core::Constants::M_HELP)->addAction(cmd, Core::Constants::G_HELP_SUPPORT); ActionManager::actionContainer(Core::Constants::M_HELP)->addAction(cmd, Core::Constants::G_HELP_SUPPORT);
connect(action, &QAction::triggered, this, &HelpPlugin::slotReportBug); connect(action, &QAction::triggered, this, [] {
QDesktopServices::openUrl(QUrl("https://bugreports.qt.io"));
});
action = new QAction(tr("System Information..."), this); action = new QAction(tr("System Information..."), this);
cmd = ActionManager::registerAction(action, "Help.SystemInformation"); cmd = ActionManager::registerAction(action, "Help.SystemInformation");
@@ -638,16 +642,6 @@ void HelpPlugin::handleHelpRequest(const QUrl &url, HelpManager::HelpViewerLocat
ICore::raiseWindow(viewer); ICore::raiseWindow(viewer);
} }
void HelpPlugin::slotOpenSupportPage()
{
showLinkInHelpMode(QUrl("qthelp://org.qt-project.qtcreator/doc/technical-support.html"));
}
void HelpPlugin::slotReportBug()
{
QDesktopServices::openUrl(QUrl("https://bugreports.qt.io"));
}
class DialogClosingOnEscape : public QDialog class DialogClosingOnEscape : public QDialog
{ {
public: public:

2
src/plugins/help/helpplugin.h
View File

@@ -98,8 +98,6 @@ private:
void highlightSearchTermsInContextHelp(); void highlightSearchTermsInContextHelp();
void handleHelpRequest(const QUrl &url, Core::HelpManager::HelpViewerLocation location); void handleHelpRequest(const QUrl &url, Core::HelpManager::HelpViewerLocation location);
void slotOpenSupportPage();
void slotReportBug();
void slotSystemInformation(); void slotSystemInformation();
void resetFilter(); void resetFilter();