feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Use new RC update indirection for DesktopRunConfig

Browse Source 
This is a minimal-invasive change, one can imagine inlining the
updateTargetInformation code in the ctor, even with direct access
to the aspects created there.

Change-Id: Ic43fe538dec33d24ad72bc651e7775e1760b2db2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-11-25 13:07:31 +01:00
parent 480fb3f66d
commit ca5ed8879f
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/projectexplorer/desktoprunconfiguration.cpp
View File

@@ -77,11 +77,13 @@ DesktopRunConfiguration::DesktopRunConfiguration(Target *target, Core::Id id, Ki
bti.runEnvModifier(env, libAspect->value()); bti.runEnvModifier(env, libAspect->value());
}); });
setUpdater([this] { updateTargetInformation(); });
if (kind == Qbs) { if (kind == Qbs) {
// Handles device changes, etc. // Handles device changes, etc.
connect(target, &Target::kitChanged, connect(target, &Target::kitChanged, this, &RunConfiguration::update);
this, &DesktopRunConfiguration::updateTargetInformation);
} else if (m_kind == CMake) { } else if (m_kind == CMake) {
@@ -89,8 +91,7 @@ DesktopRunConfiguration::DesktopRunConfiguration(Target *target, Core::Id id, Ki
} }
connect(target, &Target::buildSystemUpdated, connect(target, &Target::buildSystemUpdated, this, &RunConfiguration::update);
this, &DesktopRunConfiguration::updateTargetInformation);
} }
void DesktopRunConfiguration::updateTargetInformation() void DesktopRunConfiguration::updateTargetInformation()