feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove pointless conversions in cloneConfiguration

Browse Source 
Change-Id: I80d48ba726111d18f2ee623efa0f44a1fd6e2654
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Orgad Shaneh
2021-07-28 18:57:36 +03:00
committed by Orgad Shaneh
parent 185ceda8f1
commit cf1377b6fe
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/projectexplorer/buildsettingspropertiespage.cpp
View File

@@ -300,16 +300,13 @@ void BuildSettingsWidget::cloneConfiguration()
return; return;
bc->setDisplayName(name); bc->setDisplayName(name);
const std::function<bool(const QString &)> isBuildDirOk = [this](const QString &candidate) { const std::function<bool(const FilePath &)> isBuildDirOk = [this](const FilePath &candidate) {
const auto fp = FilePath::fromString(candidate); if (candidate.exists())
if (fp.exists())
return false; return false;
return !anyOf(m_target->buildConfigurations(), [&fp](const BuildConfiguration *bc) { return !anyOf(m_target->buildConfigurations(), [&candidate](const BuildConfiguration *bc) {
return bc->buildDirectory() == fp; }); return bc->buildDirectory() == candidate; });
}; };
bc->setBuildDirectory(FilePath::fromString(makeUniquelyNumbered( bc->setBuildDirectory(makeUniquelyNumbered(bc->buildDirectory(), isBuildDirOk));
bc->buildDirectory().toString(),
isBuildDirOk)));
m_target->addBuildConfiguration(bc); m_target->addBuildConfiguration(bc);
SessionManager::setActiveBuildConfiguration(m_target, bc, SetActive::Cascade); SessionManager::setActiveBuildConfiguration(m_target, bc, SetActive::Cascade);
} }