feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix textures not render in effect maker

Browse Source 
Task-number: QDS-11064
Change-Id: If300e61e389f66928787bf02273c9356a1a76185
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
This commit is contained in:
Amr Essam
2023-10-30 09:29:33 +02:00
committed by Amr Elsayed
parent 1204ce35b9
commit cfa46fa974
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
share/qtcreator/qmldesigner/effectMakerQmlSources/ValueImage.qml
View File

@@ -18,6 +18,7 @@ Row {
actionIndicatorVisible: false actionIndicatorVisible: false
onAbsoluteFilePathChanged: uniformValue = absoluteFilePath //TODO: Disable until we figure out how to use images from outside qds
//onAbsoluteFilePathChanged: uniformValue = absoluteFilePath
} }
} }

8
src/plugins/effectmakernew/effectmakermodel.cpp
View File

@@ -462,9 +462,11 @@ QString EffectMakerModel::valueAsVariable(const Uniform &uniform)
// Return name for the image property Image element // Return name for the image property Image element
QString EffectMakerModel::getImageElementName(const Uniform &uniform) QString EffectMakerModel::getImageElementName(const Uniform &uniform)
{ {
// TODO if (uniform.value().toString().isEmpty())
Q_UNUSED(uniform) return QStringLiteral("null");
return {}; QString simplifiedName = uniform.name().simplified();
simplifiedName = simplifiedName.remove(' ');
return QStringLiteral("imageItem") + simplifiedName;
} }
const QString EffectMakerModel::getConstVariables() const QString EffectMakerModel::getConstVariables()