feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Baremetal: Fix three compiler warnings

Browse Source 
With gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1)

plugins/baremetal/debugservers/uvsc/uvtargetdevicemodel.cpp:173:13:
warning: ‘BareMetal::Internal::Uv::PackageItem::m_file’ will be initialized after [-Wreorder]
     QString m_file;
             ^~~~~~
plugins/baremetal/debugservers/uvsc/uvtargetdevicemodel.cpp:172:13:
warning: ‘QString BareMetal::Internal::Uv::PackageItem::m_version’ [-Wreorder]
     QString m_version;
             ^~~~~~~~~
plugins/baremetal/debugservers/uvsc/uvtargetdevicemodel.cpp:155:14:
warning: when initialized here [-Wreorder]
     explicit PackageItem(const QString &file)
              ^~~~~~~~~~~

plugins/baremetal/debugservers/uvsc/uvtargetdevicemodel.cpp:500:19:
warning: suggest parentheses around assignment used as truth value [-Wparentheses]
     } while (item = item->parentPackItem());
              ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~

plugins/debugger/uvsc/uvscclient.cpp:376:14: warning: variable
‘istkenum’ set but not used [-Wunused-but-set-variable]
     iSTKENUM istkenum = {};
              ^~~~~~~~

Change-Id: I95d0868e1b3ba9162bd9a308a7d39db9daf59742
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Andre Hartmann
2020-02-16 08:37:37 +01:00
committed by André Hartmann
parent b3cf553e1a
commit d0a11322f4
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/baremetal/debugservers/uvsc/uvtargetdevicemodel.cpp
View File

@@ -169,8 +169,8 @@ public:
return {};
}
QString m_version;
QString m_file;
QString m_version;
QString m_desc;
QString m_vendor;
QString m_url;
@@ -497,7 +497,7 @@ DeviceSelection DeviceSelectionView::buildSelection(const DeviceSelectionItem *i
default:
break;
}
} while (item = item->parentPackItem());
} while ((item = item->parentPackItem()));
return selection;
}

5
src/plugins/debugger/uvsc/uvscclient.cpp
View File

@@ -373,11 +373,6 @@ bool UvscClient::fetchStackFrames(quint32 taskId, quint64 address, GdbMi &data)
if (!checkConnection())
return false;
iSTKENUM istkenum = {};
istkenum.task = taskId;
istkenum.isFull = true;
istkenum.hasExtended = true;
std::vector<STACKENUM> stackenums;
const bool success = enumerateStack(taskId, stackenums);
if (!success) {