feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LanguageClient: fix crash in completion assist

Browse Source 
Check m_processor again after starting. There is a callback resetting
the processor and we cannot ensure that starting the processor does not
result in calling this callback.

Change-Id: I4dca31399fb5224234c81df36edcb7b75d9ceaef
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
David Schulz
2023-12-13 10:10:15 +01:00
parent 828f78ccd3
commit d24e575278
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/languageclient/languageclientcompletionassist.cpp
View File

@@ -317,7 +317,7 @@ public:
}); });
setProposal(m_processor->start(std::move(interface)), prefix); setProposal(m_processor->start(std::move(interface)), prefix);
if (!m_processor->running()) { if (m_processor && !m_processor->running()) {
delete m_processor; delete m_processor;
m_processor = nullptr; m_processor = nullptr;
} }