feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Axivion: Don't store issue id inside AxivionTextMark

Browse Source 
Pass it directly to internal lambdas instead.

Change-Id: I2f09004c0fe005e47610a054e308ded19619c438
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Jarek Kobus
2024-02-02 11:20:43 +01:00
parent 6dc54d5506
commit daedaf3d1c
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/axivion/axivionplugin.cpp
View File

@@ -157,14 +157,10 @@ class AxivionTextMark : public TextEditor::TextMark
{ {
public: public:
AxivionTextMark(const FilePath &filePath, const ShortIssue &issue); AxivionTextMark(const FilePath &filePath, const ShortIssue &issue);
private:
QString m_id;
}; };
AxivionTextMark::AxivionTextMark(const FilePath &filePath, const ShortIssue &issue) AxivionTextMark::AxivionTextMark(const FilePath &filePath, const ShortIssue &issue)
: TextEditor::TextMark(filePath, issue.lineNumber, {Tr::tr("Axivion"), AxivionTextMarkId}) : TextEditor::TextMark(filePath, issue.lineNumber, {Tr::tr("Axivion"), AxivionTextMarkId})
, m_id(issue.id)
{ {
const QString markText = issue.entity.isEmpty() ? issue.message const QString markText = issue.entity.isEmpty() ? issue.message
: issue.entity + ": " + issue.message; : issue.entity + ": " + issue.message;
@@ -172,11 +168,11 @@ AxivionTextMark::AxivionTextMark(const FilePath &filePath, const ShortIssue &iss
setIcon(iconForIssue("SV")); // FIXME adapt to the issue setIcon(iconForIssue("SV")); // FIXME adapt to the issue
setPriority(TextEditor::TextMark::NormalPriority); setPriority(TextEditor::TextMark::NormalPriority);
setLineAnnotation(markText); setLineAnnotation(markText);
setActionsProvider([this]{ setActionsProvider([id = issue.id] {
auto action = new QAction; auto action = new QAction;
action->setIcon(Utils::Icons::INFO.icon()); action->setIcon(Utils::Icons::INFO.icon());
action->setToolTip(Tr::tr("Show rule details")); action->setToolTip(Tr::tr("Show rule details"));
QObject::connect(action, &QAction::triggered, dd, [this] { dd->fetchIssueInfo(m_id); }); QObject::connect(action, &QAction::triggered, dd, [id] { dd->fetchIssueInfo(id); });
return QList{action}; return QList{action};
}); });
} }