ProjectExplorer: Remove BuildStepListWidget::additionalSummaryText()

... and related code.

The base implementation returns an empty string, the only re-implemented
version in the qmake step returned a member that has been empty since
243145621 "Profile introduction" in 2012.

Change-Id: Ifafdc1b88bf4a96cdca5b48d9ccf47b63d9d987a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

src/plugins/projectexplorer/buildstep.h

@@ -174,7 +174,6 @@ public:
     BuildStepConfigWidget(BuildStep *step, bool showWidget = true);
 
     virtual QString summaryText() const;
-    virtual QString additionalSummaryText() const { return QString(); }
 
     QString displayName() const;
     BuildStep *step() const { return m_step; }
@@ -184,7 +183,6 @@ public:
 
 signals:
     void updateSummary();
-    void updateAdditionalSummary();
 
 private:
     BuildStep *m_step = nullptr;

src/plugins/projectexplorer/buildstepspage.cpp

@@ -182,7 +182,6 @@ BuildStepsWidgetData::BuildStepsWidgetData(BuildStep *s) :
     detailsWidget->setToolWidget(toolWidget);
     detailsWidget->setContentsMargins(0, 0, 0, 1);
     detailsWidget->setSummaryText(widget->summaryText());
-    detailsWidget->setAdditionalSummaryText(widget->additionalSummaryText());
 }
 
 BuildStepsWidgetData::~BuildStepsWidgetData()
@@ -214,19 +213,6 @@ void BuildStepListWidget::updateSummary()
     }
 }
 
-void BuildStepListWidget::updateAdditionalSummary()
-{
-    auto widget = qobject_cast<BuildStepConfigWidget *>(sender());
-    if (widget) {
-        foreach (const BuildStepsWidgetData *s, m_buildStepsData) {
-            if (s->widget == widget) {
-                s->detailsWidget->setAdditionalSummaryText(widget->additionalSummaryText());
-                break;
-            }
-        }
-    }
-}
-
 void BuildStepListWidget::updateEnabledState()
 {
     auto step = qobject_cast<BuildStep *>(sender());
@@ -329,8 +315,6 @@ void BuildStepListWidget::addBuildStepWidget(int pos, BuildStep *step)
 
     connect(s->widget, &BuildStepConfigWidget::updateSummary,
             this, &BuildStepListWidget::updateSummary);
-    connect(s->widget, &BuildStepConfigWidget::updateAdditionalSummary,
-            this, &BuildStepListWidget::updateAdditionalSummary);
 
     connect(s->step, &BuildStep::enabledChanged,
             this, &BuildStepListWidget::updateEnabledState);

src/plugins/projectexplorer/buildstepspage.h

@@ -106,7 +106,6 @@ private:
     void updateAddBuildStepMenu();
     void addBuildStep(int pos);
     void updateSummary();
-    void updateAdditionalSummary();
     void updateEnabledState();
     void stepMoved(int from, int to);
     void removeBuildStep(int pos);

src/plugins/qmakeprojectmanager/qmakestep.cpp

@@ -621,11 +621,6 @@ QString QMakeStepConfigWidget::summaryText() const
     return m_summaryText;
 }
 
-QString QMakeStepConfigWidget::additionalSummaryText() const
-{
-    return m_additionalSummaryText;
-}
-
 void QMakeStepConfigWidget::qtVersionChanged()
 {
     updateSummaryLabel();

src/plugins/qmakeprojectmanager/qmakestep.h

@@ -199,7 +199,6 @@ public:
     QMakeStepConfigWidget(QMakeStep *step);
     ~QMakeStepConfigWidget() override;
     QString summaryText() const override;
-    QString additionalSummaryText() const override;
 
 private:
     // slots for handling buildconfiguration/step signals
@@ -230,7 +229,6 @@ private:
     Internal::Ui::QMakeStep *m_ui = nullptr;
     QMakeStep *m_step = nullptr;
     QString m_summaryText;
-    QString m_additionalSummaryText;
     bool m_ignoreChange = false;
 };