ProjectExplorer: Remove unneeded #include in projectexplorer.h

And fix side effects.

Change-Id: Ib6f0c5618092f80204b409edec0a92004f2350d2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>

src/plugins/clangcodemodel/clangcodemodelplugin.cpp

@@ -55,6 +55,7 @@
 #include <texteditor/textmark.h>
 
 #include <utils/temporarydirectory.h>
+#include <utils/qtcassert.h>
 #include <utils/runextensions.h>
 
 using namespace Utils;

src/plugins/cmakeprojectmanager/fileapireader.cpp

@@ -34,6 +34,7 @@
 #include <projectexplorer/projectexplorer.h>
 
 #include <utils/algorithm.h>
+#include <utils/qtcassert.h>
 #include <utils/runextensions.h>
 
 #include <QLoggingCategory>

src/plugins/cppeditor/cppmodelmanager_test.cpp

@@ -37,12 +37,15 @@
 #include <coreplugin/editormanager/editormanager.h>
 #include <coreplugin/fileutils.h>
 #include <coreplugin/testdatadir.h>
+
+#include <cplusplus/LookupContext.h>
+
 #include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/session.h>
 
-#include <cplusplus/LookupContext.h>
 #include <utils/executeondestruction.h>
 #include <utils/hostosinfo.h>
+#include <utils/qtcassert.h>
 
 #include <QDebug>
 #include <QtTest>

src/plugins/cppeditor/cpptoolstestcase.cpp

@@ -34,19 +34,23 @@
 #include "projectinfo.h"
 
 #include <coreplugin/editormanager/editormanager.h>
+
+#include <cplusplus/CppDocument.h>
+
 #include <projectexplorer/buildsystem.h>
 #include <projectexplorer/project.h>
 #include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/session.h>
+
 #include <texteditor/texteditor.h>
 #include <texteditor/codeassist/iassistproposal.h>
 #include <texteditor/codeassist/iassistproposalmodel.h>
 #include <texteditor/storagesettings.h>
 
-#include <cplusplus/CppDocument.h>
 #include <utils/executeondestruction.h>
 #include <utils/fileutils.h>
 #include <utils/hostosinfo.h>
+#include <utils/qtcassert.h>
 #include <utils/temporarydirectory.h>
 
 #include <QtTest>

src/plugins/projectexplorer/projectexplorer.h

@@ -26,27 +26,28 @@
 #pragma once
 
 #include "projectexplorer_export.h"
-#include "runconfiguration.h"
 
 #include <extensionsystem/iplugin.h>
 
+#include <utils/filepath.h>
+#include <utils/id.h>
+
 #include <QPair>
 
 QT_BEGIN_NAMESPACE
 class QPoint;
-class QAction;
 class QThreadPool;
 QT_END_NAMESPACE
 
 namespace Core {
 class IMode;
 class OutputWindow;
-} // namespace Core
+} // Core
 
 namespace Utils {
+class CommandLine;
 class ProcessHandle;
-class FilePath;
-}
+} // Utils
 
 namespace ProjectExplorer {
 class BuildPropertiesSettings;
@@ -56,7 +57,6 @@ class RunConfiguration;
 class Project;
 class Node;
 class FolderNode;
-class FileNode;
 
 namespace Internal {
 class AppOutputSettings;

src/plugins/projectexplorer/projectmodels.cpp

@@ -34,15 +34,19 @@
 #include "target.h"
 
 #include <app/app_version.h>
+
 #include <coreplugin/documentmanager.h>
 #include <coreplugin/icore.h>
 #include <coreplugin/iversioncontrol.h>
 #include <coreplugin/vcsmanager.h>
+
 #include <utils/utilsicons.h>
 #include <utils/algorithm.h>
 #include <utils/dropsupport.h>
 #include <utils/fsengine/fileiconprovider.h>
 #include <utils/pathchooser.h>
+#include <utils/qtcassert.h>
+#include <utils/qtcprocess.h>
 #include <utils/stringutils.h>
 #include <utils/theme/theme.h>
 

src/plugins/projectexplorer/projectwelcomepage.cpp

@@ -40,6 +40,7 @@
 #include <utils/algorithm.h>
 #include <utils/fileutils.h>
 #include <utils/icon.h>
+#include <utils/qtcassert.h>
 #include <utils/stringutils.h>
 #include <utils/theme/theme.h>
 

src/plugins/projectexplorer/session.cpp

@@ -48,10 +48,10 @@
 
 #include <utils/algorithm.h>
 #include <utils/stylehelper.h>
+#include <utils/qtcassert.h>
 
 #include <QDebug>
 #include <QDir>
-#include <QFileInfo>
 #include <QMessageBox>
 #include <QPushButton>
 

src/plugins/projectexplorer/taskfile.cpp

@@ -32,8 +32,11 @@
 
 #include <coreplugin/documentmanager.h>
 #include <coreplugin/icore.h>
+
 #include <utils/algorithm.h>
-#include <utils/fileutils.h>
+#include <utils/filepath.h>
+#include <utils/qtcassert.h>
+#include <utils/qtcprocess.h>
 
 #include <QAction>
 #include <QMessageBox>

src/plugins/qbsprojectmanager/qbsbuildconfiguration.cpp

@@ -41,6 +41,7 @@
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/projectexplorerconstants.h>
+#include <projectexplorer/runconfiguration.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/toolchain.h>
 

src/plugins/qmakeprojectmanager/externaleditors.cpp

@@ -25,17 +25,21 @@
 
 #include "externaleditors.h"
 
-#include <utils/algorithm.h>
-#include <utils/hostosinfo.h>
-#include <utils/qtcprocess.h>
 #include <projectexplorer/project.h>
 #include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/session.h>
+
 #include <qtsupport/qtkitinformation.h>
+
 #include <designer/designerconstants.h>
 
+#include <utils/algorithm.h>
+#include <utils/hostosinfo.h>
+#include <utils/qtcassert.h>
+#include <utils/qtcprocess.h>
+
 #include <QDebug>
 #include <QTcpServer>
 #include <QTcpSocket>

src/plugins/qmakeprojectmanager/librarydetailscontroller.cpp

@@ -32,7 +32,9 @@
 #include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/session.h>
 #include <projectexplorer/target.h>
+
 #include <utils/hostosinfo.h>
+#include <utils/qtcassert.h>
 #include <utils/qtcprocess.h>
 
 #include <QFileInfo>

src/plugins/qmakeprojectmanager/qmakebuildconfiguration.cpp

@@ -49,6 +49,7 @@
 #include <projectexplorer/makestep.h>
 #include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/projectexplorerconstants.h>
+#include <projectexplorer/runconfiguration.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/toolchain.h>
 

src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp

@@ -29,18 +29,22 @@
 #include "qmakeprojectmanagerconstants.h"
 
 #include <android/androidconstants.h>
+
 #include <coreplugin/documentmanager.h>
 #include <coreplugin/editormanager/editormanager.h>
 #include <coreplugin/icore.h>
 #include <coreplugin/iversioncontrol.h>
 #include <coreplugin/vcsmanager.h>
 #include <cppeditor/cppeditorconstants.h>
+
 #include <projectexplorer/editorconfiguration.h>
 #include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/taskhub.h>
+
 #include <qtsupport/profilereader.h>
+
 #include <texteditor/icodestylepreferences.h>
 #include <texteditor/tabsettings.h>
 #include <texteditor/texteditorsettings.h>
@@ -49,6 +53,7 @@
 #include <utils/algorithm.h>
 #include <utils/filesystemwatcher.h>
 #include <utils/mimeutils.h>
+#include <utils/qtcassert.h>
 #include <utils/qtcprocess.h>
 #include <utils/stringutils.h>
 #include <utils/temporarydirectory.h>

src/plugins/qtsupport/gettingstartedwelcomepage.cpp

@@ -28,13 +28,6 @@
 #include "exampleslistmodel.h"
 #include "qtsupporttr.h"
 
-#include <utils/algorithm.h>
-#include <utils/fileutils.h>
-#include <utils/pathchooser.h>
-#include <utils/stylehelper.h>
-#include <utils/theme/theme.h>
-#include <utils/winutils.h>
-
 #include <coreplugin/coreconstants.h>
 #include <coreplugin/documentmanager.h>
 #include <coreplugin/icore.h>
@@ -46,6 +39,14 @@
 #include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/projectexplorerconstants.h>
 
+#include <utils/algorithm.h>
+#include <utils/fileutils.h>
+#include <utils/pathchooser.h>
+#include <utils/qtcassert.h>
+#include <utils/stylehelper.h>
+#include <utils/theme/theme.h>
+#include <utils/winutils.h>
+
 #include <QComboBox>
 #include <QDesktopServices>
 #include <QDialogButtonBox>

src/plugins/qtsupport/qtbuildaspects.cpp

@@ -35,6 +35,7 @@
 
 #include <utils/infolabel.h>
 #include <utils/layoutbuilder.h>
+#include <utils/qtcassert.h>
 
 #include <QCheckBox>
 #include <QLayout>