feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

UnitTests: Clean up line prefixer test

Browse Source 
In TDD development is a standard advised that you setup you values in the
block, run what you want to test in the second and assert in third. We
should try to stick it because it makes reading the test easier.

It is advised too put the setup code after the test if possible.

I used const QList<QByteArray> inputChunks = {"hello\n"} instead of
const QList<QByteArray> inputChunks {"hello\n"} because it is always using
the initializer_list constructor.

Change-Id: I1573566efc1327a2d8681e9ae7bd0ad6ee182789
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Marco Bubke
2016-07-19 17:53:00 +02:00
committed by Tim Jenssen
parent 3b233033b9
commit e08c1a39e7
1 changed files with 65 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

108
tests/unit/unittest/lineprefixertest.cpp
View File

@@ -32,84 +32,106 @@
namespace {
QByteArray runPrefixer(QList<QByteArray> inputChunks)
{
QByteArray actualOutput;
ClangBackEnd::LinePrefixer prefixer("PREFIX ");
foreach (const QByteArray &chunk, inputChunks)
actualOutput += prefixer.prefix(chunk);
return actualOutput;
}
QByteArray runPrefixer(QList<QByteArray> inputChunks);
TEST(LinePrefixer, OneChunkEndsWithNewline)
{
const QList<QByteArray> inputChunks { "hello\n" };
ASSERT_THAT(Utf8String::fromByteArray(runPrefixer(inputChunks)),
Utf8String::fromUtf8("PREFIX hello\n"));
const QList<QByteArray> inputChunks = {"hello\n"};
auto text = runPrefixer(inputChunks);
ASSERT_THAT(text, "PREFIX hello\n");
}
TEST(LinePrefixer, OneChunkEndsWithoutNewline)
{
const QList<QByteArray> inputChunks { "hello" };
ASSERT_THAT(Utf8String::fromByteArray(runPrefixer(inputChunks)),
Utf8String::fromUtf8("PREFIX hello"));
const QList<QByteArray> inputChunks = {"hello"};
auto text = runPrefixer(inputChunks);
ASSERT_THAT(text, "PREFIX hello");
}
TEST(LinePrefixer, OneChunkStartsWithNewline)
{
const QList<QByteArray> inputChunks { "\nhello" };
ASSERT_THAT(Utf8String::fromByteArray(runPrefixer(inputChunks)),
Utf8String::fromUtf8("PREFIX \n"
"PREFIX hello"));
const QList<QByteArray> inputChunks = {"\nhello"};
auto text = runPrefixer(inputChunks);
ASSERT_THAT(text, "PREFIX \n"
"PREFIX hello");
}
TEST(LinePrefixer, OneChunkStartsAndEndsWithNewline)
{
const QList<QByteArray> inputChunks { "\nhello\n" };
ASSERT_THAT(Utf8String::fromByteArray(runPrefixer(inputChunks)),
Utf8String::fromUtf8("PREFIX \n"
"PREFIX hello\n"));
const QList<QByteArray> inputChunks = {"\nhello\n"};
auto text = runPrefixer(inputChunks);
ASSERT_THAT(text, "PREFIX \n"
"PREFIX hello\n");
}
TEST(LinePrefixer, OneChunkEndsWithExtraNewline)
{
const QList<QByteArray> inputChunks { "hello\n\n" };
ASSERT_THAT(Utf8String::fromByteArray(runPrefixer(inputChunks)),
Utf8String::fromUtf8("PREFIX hello\n"
"PREFIX \n"));
const QList<QByteArray> inputChunks = {"hello\n\n"};
auto text = runPrefixer(inputChunks);
ASSERT_THAT(text, "PREFIX hello\n"
"PREFIX \n");
}
TEST(LinePrefixer, OneChunkEndsWithTwoExtraNewlines)
{
const QList<QByteArray> inputChunks { "hello\n\n\n" };
ASSERT_THAT(Utf8String::fromByteArray(runPrefixer(inputChunks)),
Utf8String::fromUtf8("PREFIX hello\n"
"PREFIX \n"
"PREFIX \n"));
const QList<QByteArray> inputChunks = {"hello\n\n\n"};
auto text = runPrefixer(inputChunks);
ASSERT_THAT(text, "PREFIX hello\n"
"PREFIX \n"
"PREFIX \n");
}
TEST(LinePrefixer, ChunkWithoutNewlineAndChunkWithNewline)
{
const QList<QByteArray> inputChunks { "hello", "\n" };
ASSERT_THAT(Utf8String::fromByteArray(runPrefixer(inputChunks)),
Utf8String::fromUtf8("PREFIX hello\n"));
const QList<QByteArray> inputChunks = {"hello", "\n"};
auto text = runPrefixer(inputChunks);
ASSERT_THAT(text, "PREFIX hello\n");
}
TEST(LinePrefixer, ChunkWithoutNewlineAndChunkWithTwoNewlines)
{
const QList<QByteArray> inputChunks { "hello", "\n\n" };
ASSERT_THAT(Utf8String::fromByteArray(runPrefixer(inputChunks)),
Utf8String::fromUtf8("PREFIX hello\n"
"PREFIX \n"));
const QList<QByteArray> inputChunks = {"hello", "\n\n"};
auto text = runPrefixer(inputChunks);
ASSERT_THAT(text, "PREFIX hello\n"
"PREFIX \n");
}
TEST(LinePrefixer, ChunkWithTwoNewlinesAndChunkWithoutNewline)
{
const QList<QByteArray> inputChunks { "\n\n", "hello" };
ASSERT_THAT(Utf8String::fromByteArray(runPrefixer(inputChunks)),
Utf8String::fromUtf8("PREFIX \n"
"PREFIX \n"
"PREFIX hello"));
const QList<QByteArray> inputChunks = {"\n\n", "hello"};
auto text = runPrefixer(inputChunks);
ASSERT_THAT(text, "PREFIX \n"
"PREFIX \n"
"PREFIX hello");
}
QByteArray runPrefixer(QList<QByteArray> inputChunks)
{
QByteArray actualOutput;
ClangBackEnd::LinePrefixer prefixer("PREFIX ");
for (const auto &chunk : inputChunks)
actualOutput += prefixer.prefix(chunk);
return actualOutput;
}
} // anonymous namespace