forked from qt-creator/qt-creator
Debugger: Simplify *SlaveEngineType StartParameters members
The secondSlaveEngineType was not really used, and the first either NoEngineType or identical to the cppEngineType. Change-Id: I1725728ca38636f228ff9b9d8ca7d643a34c64e8 Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This commit is contained in:
@@ -414,13 +414,10 @@ DebuggerRunControl *DebuggerRunControlFactory::doCreate
|
||||
const bool useCppDebugger = aspect->useCppDebugger() && (sp.languages & CppLanguage);
|
||||
const bool useQmlDebugger = aspect->useQmlDebugger() && (sp.languages & QmlLanguage);
|
||||
if (useQmlDebugger) {
|
||||
if (useCppDebugger) {
|
||||
if (useCppDebugger)
|
||||
sp.masterEngineType = QmlCppEngineType;
|
||||
sp.firstSlaveEngineType = sp.cppEngineType;
|
||||
sp.secondSlaveEngineType = QmlCppEngineType;
|
||||
} else {
|
||||
else
|
||||
sp.masterEngineType = QmlEngineType;
|
||||
}
|
||||
} else {
|
||||
sp.masterEngineType = sp.cppEngineType;
|
||||
}
|
||||
|
@@ -79,8 +79,6 @@ public:
|
||||
|
||||
DebuggerStartParameters()
|
||||
: masterEngineType(NoEngineType),
|
||||
firstSlaveEngineType(NoEngineType),
|
||||
secondSlaveEngineType(NoEngineType),
|
||||
cppEngineType(NoEngineType),
|
||||
runConfiguration(0),
|
||||
isSnapshot(false),
|
||||
@@ -102,11 +100,7 @@ public:
|
||||
testCase(0)
|
||||
{}
|
||||
|
||||
//Core::Id profileId;
|
||||
|
||||
DebuggerEngineType masterEngineType;
|
||||
DebuggerEngineType firstSlaveEngineType;
|
||||
DebuggerEngineType secondSlaveEngineType;
|
||||
DebuggerEngineType cppEngineType;
|
||||
QString sysRoot;
|
||||
QString deviceSymbolsRoot;
|
||||
|
@@ -74,7 +74,7 @@ QmlCppEngine::QmlCppEngine(const DebuggerStartParameters &sp, QString *errorMess
|
||||
{
|
||||
setObjectName(QLatin1String("QmlCppEngine"));
|
||||
m_qmlEngine = new QmlEngine(sp, this);
|
||||
m_cppEngine = DebuggerRunControlFactory::createEngine(sp.firstSlaveEngineType, sp, errorMessage);
|
||||
m_cppEngine = DebuggerRunControlFactory::createEngine(sp.cppEngineType, sp, errorMessage);
|
||||
if (!m_cppEngine) {
|
||||
*errorMessage = tr("The slave debugging engine required for combined QML/C++-Debugging could not be created: %1").arg(*errorMessage);
|
||||
return;
|
||||
|
Reference in New Issue
Block a user