feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

FilePath: optimize comparison

Browse Source 
* The QTC_ASSERT in pathView() is quite expensive
* Constructing the scheme using scheme() is not required

Change-Id: Ibea33dd6abf67c8bd184d118f23e2598075c362c
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Thomas Hartmann
2022-11-18 09:19:12 +01:00
parent 6046fa8354
commit e471417539
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/libs/utils/filepath.cpp
View File

@@ -342,7 +342,6 @@ QStringView FilePath::host() const
QStringView FilePath::pathView() const
{
QTC_ASSERT(!m_data.startsWith(u"/./"), return m_data.mid(3, m_pathLen - 3));
return m_data.left(m_pathLen);
}
@@ -1342,7 +1341,7 @@ bool FilePath::isNewerThan(const QDateTime &timeStamp) const
*/
Qt::CaseSensitivity FilePath::caseSensitivity() const
{
if (scheme().isEmpty())
if (m_schemeLen == 0)
return HostOsInfo::fileNameCaseSensitivity();
// FIXME: This could or possibly should the target device's file name case sensitivity