feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

NavigationWidget: Avoid using keys()

Browse Source 
Instead, iterate directly over the container.

Change-Id: I393ac1d42b08b7fcf2052ba601a550f28ad84c69
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2024-01-11 00:32:16 +01:00
parent b653dc3e80
commit e4866a1667
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/coreplugin/navigationwidget.cpp
View File

@@ -451,10 +451,9 @@ void NavigationWidget::saveSettings(QtcSettings *settings)
settings->setValue(settingsKey("Width"), d->m_width); settings->setValue(settingsKey("Width"), d->m_width);
const Key activationKey = "ActivationPosition."; const Key activationKey = "ActivationPosition.";
const auto keys = s_activationsMap.keys(); for (auto it = s_activationsMap.cbegin(); it != s_activationsMap.cend(); ++it) {
for (const auto &factoryId : keys) { const auto &info = *it;
const auto &info = s_activationsMap[factoryId]; const Utils::Key key = settingsKey(activationKey + it.key().name());
const Utils::Key key = settingsKey(activationKey + factoryId.name());
if (info.side == d->m_side) if (info.side == d->m_side)
settings->setValue(key, info.position); settings->setValue(key, info.position);
else else