forked from qt-creator/qt-creator
RunWorker: Remove recordData() / recordedData() methods
Since there is no more usages of recordedData() - get rid of it. Thus storing any data without using them doesn't make sense. Change-Id: I1b527d22cc8a53b4f8df960ba9fd3d3436d7b822 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
@@ -26,10 +26,7 @@ public:
|
|||||||
auto worker = runControl->createWorker(runnerIdForRunMode(runControl->runMode()));
|
auto worker = runControl->createWorker(runnerIdForRunMode(runControl->runMode()));
|
||||||
worker->addStartDependency(this);
|
worker->addStartDependency(this);
|
||||||
|
|
||||||
connect(runner, &AndroidRunner::qmlServerReady, this, [this, worker](const QUrl &server) {
|
connect(runner, &AndroidRunner::qmlServerReady, this, &RunWorker::reportStarted);
|
||||||
worker->recordData("QmlServerUrl", server);
|
|
||||||
reportStarted();
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
@@ -735,7 +735,6 @@ void IosQmlProfilerSupport::start()
|
|||||||
|
|
||||||
Port qmlPort = m_runner->qmlServerPort();
|
Port qmlPort = m_runner->qmlServerPort();
|
||||||
serverUrl.setPort(qmlPort.number());
|
serverUrl.setPort(qmlPort.number());
|
||||||
m_profiler->recordData("QmlServerUrl", serverUrl);
|
|
||||||
if (qmlPort.isValid())
|
if (qmlPort.isValid())
|
||||||
reportStarted();
|
reportStarted();
|
||||||
else
|
else
|
||||||
|
@@ -235,7 +235,6 @@ public:
|
|||||||
QList<RunWorker *> stopDependencies;
|
QList<RunWorker *> stopDependencies;
|
||||||
QString id;
|
QString id;
|
||||||
|
|
||||||
Store data;
|
|
||||||
bool supportsReRunning = true;
|
bool supportsReRunning = true;
|
||||||
bool essential = false;
|
bool essential = false;
|
||||||
};
|
};
|
||||||
@@ -1951,16 +1950,6 @@ void RunWorker::setId(const QString &id)
|
|||||||
d->id = id;
|
d->id = id;
|
||||||
}
|
}
|
||||||
|
|
||||||
void RunWorker::recordData(const Key &channel, const QVariant &data)
|
|
||||||
{
|
|
||||||
d->data[channel] = data;
|
|
||||||
}
|
|
||||||
|
|
||||||
QVariant RunWorker::recordedData(const Key &channel) const
|
|
||||||
{
|
|
||||||
return d->data[channel];
|
|
||||||
}
|
|
||||||
|
|
||||||
void RunWorker::setSupportsReRunning(bool reRunningSupported)
|
void RunWorker::setSupportsReRunning(bool reRunningSupported)
|
||||||
{
|
{
|
||||||
d->supportsReRunning = reRunningSupported;
|
d->supportsReRunning = reRunningSupported;
|
||||||
|
@@ -56,9 +56,6 @@ public:
|
|||||||
|
|
||||||
void setId(const QString &id);
|
void setId(const QString &id);
|
||||||
|
|
||||||
void recordData(const Utils::Key &channel, const QVariant &data);
|
|
||||||
QVariant recordedData(const Utils::Key &channel) const;
|
|
||||||
|
|
||||||
// Part of read-only interface of RunControl for convenience.
|
// Part of read-only interface of RunControl for convenience.
|
||||||
void appendMessage(const QString &msg, Utils::OutputFormat format, bool appendNewLine = true);
|
void appendMessage(const QString &msg, Utils::OutputFormat format, bool appendNewLine = true);
|
||||||
IDeviceConstPtr device() const;
|
IDeviceConstPtr device() const;
|
||||||
|
@@ -277,7 +277,6 @@ public:
|
|||||||
private:
|
private:
|
||||||
void start() final
|
void start() final
|
||||||
{
|
{
|
||||||
m_worker->recordData("QmlServerUrl", qmlChannel());
|
|
||||||
reportStarted();
|
reportStarted();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user