feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Simplify LLDB bridge startup

Browse Source 
No need to start the debugger event loop if the engine setup fails

Change-Id: I6bdeda0d2609c79aa5fafff7bc4b373a0bf14fbd
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2020-05-05 12:49:01 +02:00
parent 4744473555
commit e73f05253e
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
share/qtcreator/debugger/lldbbridge.py
View File

@@ -108,7 +108,6 @@ class Dumper(DumperBase):
self.process = None self.process = None
self.target = None self.target = None
self.eventState = lldb.eStateInvalid self.eventState = lldb.eStateInvalid
self.runEngineAttempted = False
self.executable_ = None self.executable_ = None
self.symbolFile_ = None self.symbolFile_ = None
@@ -923,14 +922,6 @@ class Dumper(DumperBase):
% (state, error, self.executable_), args) % (state, error, self.executable_), args)
def runEngine(self, args): def runEngine(self, args):
if self.runEngineAttempted:
return
self.runEngineAttempted = True
self.prepare(args)
s = threading.Thread(target=self.loop, args=[])
s.start()
def prepare(self, args):
error = lldb.SBError() error = lldb.SBError()
if self.attachPid_ > 0 and self.platform_ != "remote-linux": if self.attachPid_ > 0 and self.platform_ != "remote-linux":
@@ -999,6 +990,9 @@ class Dumper(DumperBase):
self.report('pid="%s"' % self.process.GetProcessID()) self.report('pid="%s"' % self.process.GetProcessID())
self.reportState('enginerunandinferiorrunok') self.reportState('enginerunandinferiorrunok')
s = threading.Thread(target=self.loop, args=[])
s.start()
def loop(self): def loop(self):
event = lldb.SBEvent() event = lldb.SBEvent()
#broadcaster = self.target.GetBroadcaster() #broadcaster = self.target.GetBroadcaster()