feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

PE: Fix possible crash

Browse Source 
In case of an invalid device we may crash when trying
to generate a build directory path.
Prevent this by leaving earlier.

Change-Id: Ieb02abd98467693d38df6dde434e2a6962e4d137
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
Christian Stenger
2024-12-11 08:25:34 +01:00
parent a952ab4dd7
commit e8383bc3b2
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/buildconfiguration.cpp
View File

@@ -644,6 +644,8 @@ FilePath BuildConfiguration::buildDirectoryFromTemplate(const FilePath &projectD
buildDir = buildDir.withNewPath(buildDir.path().replace(" ", "-")); buildDir = buildDir.withNewPath(buildDir.path().replace(" ", "-"));
auto buildDevice = BuildDeviceKitAspect::device(kit); auto buildDevice = BuildDeviceKitAspect::device(kit);
if (!buildDevice)
return buildDir;
if (buildDir.isAbsolutePath()) if (buildDir.isAbsolutePath())
return buildDevice->rootPath().withNewMappedPath(buildDir); return buildDevice->rootPath().withNewMappedPath(buildDir);