feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: Avoid using keys()

Browse Source 
Instead, iterate directly over the container.

Change-Id: I722dcf811a112b1b4845dcbcd6efe78cfe3b2e49
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Jarek Kobus
2024-01-07 06:05:36 +01:00
parent edb8b0aeb7
commit e98e5cc980
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/android/sdkmanageroutputparser_test.cpp
View File

@@ -28,7 +28,7 @@ void SdkManagerOutputParserTest::testParseMarkers_data()
QTest::addColumn<QString>("output");
QTest::addColumn<SdkManagerOutputParser::MarkerTag>("markerTag");
QMap<SdkManagerOutputParser::MarkerTag, QString> testData
const QMap<SdkManagerOutputParser::MarkerTag, QString> testData
= {{SdkManagerOutputParser::MarkerTag::InstalledPackagesMarker, "Installed packages:"},
{SdkManagerOutputParser::MarkerTag::AvailablePackagesMarkers, "Available Packages:"},
{SdkManagerOutputParser::MarkerTag::AvailableUpdatesMarker, "Available Updates:"},
@@ -44,8 +44,8 @@ void SdkManagerOutputParserTest::testParseMarkers_data()
{SdkManagerOutputParser::MarkerTag::CmdlineSdkToolsMarker, "cmdline-tools"},
{SdkManagerOutputParser::MarkerTag::GenericToolMarker, "sources;android-32"}};
for (const SdkManagerOutputParser::MarkerTag data : testData.keys())
QTest::newRow(testData.value(data).toLatin1().constData()) << testData.value(data) << data;
for (auto it = testData.begin(); it != testData.end(); ++it)
QTest::newRow(it->toLatin1().constData()) << *it << it.key();
QTest::newRow("Installed packages")
<< "Installed packages:" << SdkManagerOutputParser::MarkerTag::InstalledPackagesMarker;